You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "chucheng92 (via GitHub)" <gi...@apache.org> on 2023/07/06 09:34:09 UTC

[GitHub] [calcite] chucheng92 commented on pull request #3297: [CALCITE-5819] Bump commons-collections 3.x to commons-collections4

chucheng92 commented on PR #3297:
URL: https://github.com/apache/calcite/pull/3297#issuecomment-1623339828

   > LGTM pending tests!
   > 
   > By the way, I feel that using an entire library just for the sake of using `isEmpty` in 2-3 places is an overkill. It would be great if we could get rid of it completely; if you want to explore this in a follow-up ticket/PR ping me to review.
   
   hi, @zabetak Can't agree more. I will pin you if we decide to remove this. thanks for reviewing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org