You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Alex Herbert <al...@gmail.com> on 2020/06/02 21:15:57 UTC
Re: [commons-bcel] branch master updated: Add apache-rat:check.
> On 2 Jun 2020, at 19:21, ggregory@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> ggregory pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new cfaa578 Add apache-rat:check.
> cfaa578 is described below
>
> commit cfaa578439109afe801ef4448df55d5a17271604
> Author: Gary Gregory <ga...@gmail.com>
> AuthorDate: Tue Jun 2 14:21:20 2020 -0400
>
> Add apache-rat:check.
> ---
> .travis.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 742c26b..ae77d0b 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -26,4 +26,4 @@ jdk:
> - openjdk-ea
>
> after_success:
> - - mvn -Ddoclint:none clean cobertura:cobertura coveralls:report
> + - coveralls:report
Any fails in the after_success goal will not be propagated to fail the build. Any failures here will just cause the coveralls report to not be sent.
The rat check (and others) currently exists in the default goal in the pom.xml. So you must ensure that this is run using:
—
script:
- mvn
---
The default script for a java projects is [1]:
mvn test -B
Thus no checkstyle or any other checks are performed at the moment. The rat check seems to run in the validate phase and is run under ‘mvn test’.
Adding the script tag as above will run the default goal:
clean verify apache-rat:check japicmp:cmp checkstyle:check javadoc:javadoc
You can then run cobertura in the after_success goal:
mvn clean cobertura:cobertura coveralls:report
Alex
[1] https://docs.travis-ci.com/user/languages/java/ <https://docs.travis-ci.com/user/languages/java/>
>
Re: [commons-bcel] branch master updated: Add apache-rat:check.
Posted by Gary Gregory <ga...@gmail.com>.
Thanks Alex, I updated the Travis file with your suggestions.
Gary
On Tue, Jun 2, 2020 at 5:16 PM Alex Herbert <al...@gmail.com>
wrote:
>
>
> > On 2 Jun 2020, at 19:21, ggregory@apache.org wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > ggregory pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> > new cfaa578 Add apache-rat:check.
> > cfaa578 is described below
> >
> > commit cfaa578439109afe801ef4448df55d5a17271604
> > Author: Gary Gregory <ga...@gmail.com>
> > AuthorDate: Tue Jun 2 14:21:20 2020 -0400
> >
> > Add apache-rat:check.
> > ---
> > .travis.yml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 742c26b..ae77d0b 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -26,4 +26,4 @@ jdk:
> > - openjdk-ea
> >
> > after_success:
> > - - mvn -Ddoclint:none clean cobertura:cobertura coveralls:report
> > + - coveralls:report
>
> Any fails in the after_success goal will not be propagated to fail the
> build. Any failures here will just cause the coveralls report to not be
> sent.
>
> The rat check (and others) currently exists in the default goal in the
> pom.xml. So you must ensure that this is run using:
>
> —
> script:
> - mvn
> ---
>
> The default script for a java projects is [1]:
>
> mvn test -B
>
> Thus no checkstyle or any other checks are performed at the moment. The
> rat check seems to run in the validate phase and is run under ‘mvn test’.
>
> Adding the script tag as above will run the default goal:
>
> clean verify apache-rat:check japicmp:cmp checkstyle:check javadoc:javadoc
>
> You can then run cobertura in the after_success goal:
>
> mvn clean cobertura:cobertura coveralls:report
>
> Alex
>
>
> [1] https://docs.travis-ci.com/user/languages/java/ <
> https://docs.travis-ci.com/user/languages/java/>
> >
>
>