You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "amogh-jahagirdar (via GitHub)" <gi...@apache.org> on 2023/02/03 02:32:23 UTC
[GitHub] [iceberg] amogh-jahagirdar opened a new pull request, #6728: Spark: Fix isIcebergCommand check for replace branch
amogh-jahagirdar opened a new pull request, #6728:
URL: https://github.com/apache/iceberg/pull/6728
@hililiwei @jackye1995 @flyrain @yyanyy When working on the drop branch implementation, I noticed that the "or" condition for replace branch wasn't placed right in https://github.com/apache/iceberg/pull/6638 . It should be within the startsWith("alter table") condition, but currently its outside. The Iceberg DDL will still work, but the check should be more specific to match the alter table condition to prevent any future spark sql syntax change from being bypassed in the `isIcebergCommand` check.
Just raising this PR separately since it's a bugfix (albeit for an unlikely case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar closed pull request #6728: Spark: Fix isIcebergCommand check for replace branch
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar closed pull request #6728: Spark: Fix isIcebergCommand check for replace branch
URL: https://github.com/apache/iceberg/pull/6728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6728: Spark: Fix isIcebergCommand check and style issues from #6638
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #6728:
URL: https://github.com/apache/iceberg/pull/6728#issuecomment-1416272512
Thanks, I will merge the change for now, as you are working on fixing Scala checkstyle, we can make any missing changes with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on pull request #6728: Spark: Fix isIcebergCommand check and style issues from #6638
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #6728:
URL: https://github.com/apache/iceberg/pull/6728#issuecomment-1416145300
> Thanks for the fixes, let's definitely enable scala checkstyle asap to avoid issues like this.
>
> Also I think there are some other fixes in the tests that Liwei found, could you also fix those?
>
> And the title of the PR should probably change.
Done! Agreed I created https://github.com/apache/iceberg/issues/6736, to track this to avoid reviewers having to spend time on style issues in the scala codebase. I'm looking into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on a diff in pull request #6728: Spark: Fix isIcebergCommand check for replace branch
Posted by "hililiwei (via GitHub)" <gi...@apache.org>.
hililiwei commented on code in PR #6728:
URL: https://github.com/apache/iceberg/pull/6728#discussion_r1095393403
##########
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala:
##########
@@ -206,9 +206,10 @@ class IcebergSparkSqlExtensionsParser(delegate: ParserInterface) extends ParserI
normalized.contains("write unordered") ||
normalized.contains("set identifier fields") ||
normalized.contains("drop identifier fields") ||
- normalized.contains("create branch"))) ||
- normalized.contains("replace branch")
-
+ isSnapshotRefDdl(normalized)))
+ }
+ private def isSnapshotRefDdl(normalized: String): Boolean = {
Review Comment:
Add a blank line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6728: Spark: Fix isIcebergCommand check for replace branch
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #6728:
URL: https://github.com/apache/iceberg/pull/6728#issuecomment-1416139097
Thanks for the fixes, let's definitely enable scala checkstyle asap to avoid issues like this.
Also I think there are some other fixes in the tests that Liwei found, could you also fix those?
And the title of the PR should probably change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #6728: Spark: Fix isIcebergCommand check and style issues from #6638
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #6728:
URL: https://github.com/apache/iceberg/pull/6728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org