[GitHub] [beam-starter-kotlin] davidcavazos commented on a diff in pull request #1: Initial commit

[GitBox <gi...@apache.org>]

davidcavazos commented on code in PR #1:
URL: https://github.com/apache/beam-starter-kotlin/pull/1#discussion_r930444621


##########
app/src/test/kotlin/beam/starter/AppTest.kt:
##########
@@ -0,0 +1,28 @@
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// https://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or https://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+package beam.starter
+
+import org.apache.beam.sdk.testing.PAssert
+import org.apache.beam.sdk.testing.TestPipeline
+import org.junit.Rule

Review Comment:
   If we want to use `TestPipeline` it has to be a `@Rule` which is only supported on JUnit 4 (JUnit 5 is not supported). I guess we could use a "normal" pipeline and use Kotlin's tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org