You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Seetaramayya (via GitHub)" <gi...@apache.org> on 2023/02/01 21:24:27 UTC

[GitHub] [incubator-pekko-connectors-kafka] Seetaramayya commented on a diff in pull request #17: [WIP] Pekko migration

Seetaramayya commented on code in PR #17:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/17#discussion_r1093743345


##########
benchmarks/src/main/scala/org/apache/pekko/kafka/benchmarks/CsvFormatter.scala:
##########
@@ -0,0 +1,116 @@
+/*
+ * Copyright (C) 2014 - 2016 Softwaremill <https://softwaremill.com>
+ * Copyright (C) 2016 - 2020 Lightbend Inc. <https://www.lightbend.com>
+ */
+
+package org.apache.pekko.kafka.benchmarks
+
+import akka.stream.alpakka.csv.scaladsl.CsvQuotingStyle
+import org.apache.pekko.util.ByteString
+
+import java.nio.charset.{ Charset, StandardCharsets }
+import scala.collection.immutable
+
+// TODO: This needs to be deleted after migrating alpakka to pekko.

Review Comment:
   This class is `Cmd + C` and `Cmd + V` of https://github.com/apache/incubator-pekko-connectors/blob/main/csv/src/main/scala/akka/stream/alpakka/csv/scaladsl/CsvFormatting.scala 
   
   until the migration completes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org