You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/17 11:39:05 UTC

[GitHub] [superset] villebro commented on a change in pull request #17798: chore(plugin-chart-pivot-table): change order of Columns and Rows controls

villebro commented on a change in pull request #17798:
URL: https://github.com/apache/superset/pull/17798#discussion_r771329743



##########
File path: superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
##########
@@ -95,10 +95,14 @@ const config: ControlPanelConfig = {
             name: 'row_limit',
             config: {
               ...sharedControls.row_limit,
+              label: t('Cell limit'),
+              description: t('Limits the number of cells that get displayed.'),

Review comment:
       Maybe this is more accurate?
   ```suggestion
                 description: t('Limits the number of cells that get retieved.'),
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org