You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/06/20 23:29:19 UTC
[GitHub] [sling-org-apache-sling-servlets-resolver] enapps-enorman opened a new pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis
enapps-enorman opened a new pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17
org.apache.sling.commons.testing.sling.MockResourceResolver is deprecated
Expected:
use the Mock Resource Resolver Implementation from org.apache.sling.testing.resourceresolver-mock instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] enapps-enorman merged pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis
Posted by GitBox <gi...@apache.org>.
enapps-enorman merged pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] bdelacretaz commented on a change in pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on a change in pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17#discussion_r655207027
##########
File path: src/test/java/org/apache/sling/servlets/resolver/internal/helper/LocationIteratorTest.java
##########
@@ -62,62 +66,88 @@ public void testSearchPathEmpty() {
}
public void testSearchPath1Element() {
- String root0 = "/apps";
- resourceResolver.setSearchPath(root0);
+ String root0 = "/apps/";
+ resourceResolverOptions.setSearchPaths(new String[] {
+ root0
+ });
final Resource r = request.getResource();
LocationIterator li = getLocationIterator(r.getResourceType(),
r.getResourceSuperType());
// 1. /apps/foo/bar
assertTrue(li.hasNext());
- assertEquals(root0 + "/" + resourceTypePath, li.next());
+ assertEquals(root0 + resourceTypePath, li.next());
Review comment:
I'm curious. why does this slash need to go away in all tests?
##########
File path: src/test/java/org/apache/sling/servlets/resolver/internal/helper/LocationIteratorTest.java
##########
@@ -62,62 +66,88 @@ public void testSearchPathEmpty() {
}
public void testSearchPath1Element() {
- String root0 = "/apps";
- resourceResolver.setSearchPath(root0);
+ String root0 = "/apps/";
+ resourceResolverOptions.setSearchPaths(new String[] {
+ root0
+ });
final Resource r = request.getResource();
LocationIterator li = getLocationIterator(r.getResourceType(),
r.getResourceSuperType());
// 1. /apps/foo/bar
assertTrue(li.hasNext());
- assertEquals(root0 + "/" + resourceTypePath, li.next());
+ assertEquals(root0 + resourceTypePath, li.next());
Review comment:
Ok, thank you for clarifying!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] enapps-enorman commented on a change in pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17#discussion_r655495030
##########
File path: src/test/java/org/apache/sling/servlets/resolver/internal/helper/LocationIteratorTest.java
##########
@@ -62,62 +66,88 @@ public void testSearchPathEmpty() {
}
public void testSearchPath1Element() {
- String root0 = "/apps";
- resourceResolver.setSearchPath(root0);
+ String root0 = "/apps/";
+ resourceResolverOptions.setSearchPaths(new String[] {
+ root0
+ });
final Resource r = request.getResource();
LocationIterator li = getLocationIterator(r.getResourceType(),
r.getResourceSuperType());
// 1. /apps/foo/bar
assertTrue(li.hasNext());
- assertEquals(root0 + "/" + resourceTypePath, li.next());
+ assertEquals(root0 + resourceTypePath, li.next());
Review comment:
This was compensating for the search root paths (root0/root1) already having a trailing slash so adding another slash doubles up the slashes and makes the test fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] bdelacretaz commented on a change in pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on a change in pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17#discussion_r655207027
##########
File path: src/test/java/org/apache/sling/servlets/resolver/internal/helper/LocationIteratorTest.java
##########
@@ -62,62 +66,88 @@ public void testSearchPathEmpty() {
}
public void testSearchPath1Element() {
- String root0 = "/apps";
- resourceResolver.setSearchPath(root0);
+ String root0 = "/apps/";
+ resourceResolverOptions.setSearchPaths(new String[] {
+ root0
+ });
final Resource r = request.getResource();
LocationIterator li = getLocationIterator(r.getResourceType(),
r.getResourceSuperType());
// 1. /apps/foo/bar
assertTrue(li.hasNext());
- assertEquals(root0 + "/" + resourceTypePath, li.next());
+ assertEquals(root0 + resourceTypePath, li.next());
Review comment:
I'm curious. why does this slash need to go away in all tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17#issuecomment-864628396
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] bdelacretaz commented on a change in pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on a change in pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17#discussion_r655541817
##########
File path: src/test/java/org/apache/sling/servlets/resolver/internal/helper/LocationIteratorTest.java
##########
@@ -62,62 +66,88 @@ public void testSearchPathEmpty() {
}
public void testSearchPath1Element() {
- String root0 = "/apps";
- resourceResolver.setSearchPath(root0);
+ String root0 = "/apps/";
+ resourceResolverOptions.setSearchPaths(new String[] {
+ root0
+ });
final Resource r = request.getResource();
LocationIterator li = getLocationIterator(r.getResourceType(),
r.getResourceSuperType());
// 1. /apps/foo/bar
assertTrue(li.hasNext());
- assertEquals(root0 + "/" + resourceTypePath, li.next());
+ assertEquals(root0 + resourceTypePath, li.next());
Review comment:
Ok, thank you for clarifying!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17#issuecomment-867935467
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17#issuecomment-864628396
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=17&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] enapps-enorman commented on a change in pull request #17: SLING-10507 Refactor tests to replace usage of deprecated apis
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on a change in pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/17#discussion_r655495030
##########
File path: src/test/java/org/apache/sling/servlets/resolver/internal/helper/LocationIteratorTest.java
##########
@@ -62,62 +66,88 @@ public void testSearchPathEmpty() {
}
public void testSearchPath1Element() {
- String root0 = "/apps";
- resourceResolver.setSearchPath(root0);
+ String root0 = "/apps/";
+ resourceResolverOptions.setSearchPaths(new String[] {
+ root0
+ });
final Resource r = request.getResource();
LocationIterator li = getLocationIterator(r.getResourceType(),
r.getResourceSuperType());
// 1. /apps/foo/bar
assertTrue(li.hasNext());
- assertEquals(root0 + "/" + resourceTypePath, li.next());
+ assertEquals(root0 + resourceTypePath, li.next());
Review comment:
This was compensating for the search root paths (root0/root1) already having a trailing slash so adding another slash doubles up the slashes and makes the test fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org