You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/08 07:18:48 UTC
[GitHub] [spark] southernriver opened a new pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
southernriver opened a new pull request #30665:
URL: https://github.com/apache/spark/pull/30665
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
For HiveGenericUDTF , there are two initialization methods:
```
public StructObjectInspector initialize(StructObjectInspector argOIs)
throws UDFArgumentException {
List<? extends StructField> inputFields = argOIs.getAllStructFieldRefs();
ObjectInspector[] udtfInputOIs = new ObjectInspector[inputFields.size()];
for (int i = 0; i < inputFields.size(); i++) {
udtfInputOIs[i] = inputFields.get(i).getFieldObjectInspector();
}
return initialize(udtfInputOIs);
}
@Deprecated
public StructObjectInspector initialize(ObjectInspector[] argOIs)
throws UDFArgumentException {
throw new IllegalStateException("Should not be called directly");
}
```
As https://issues.apache.org/jira/browse/HIVE-5737 mentioned, hive provided StructObjectInspector for UDTFs rather than ObjectInspect[], but Spark SQL still only support deprecated function.
An exception will be reported before fix:
> Error in query: No handler for UDF/UDAF/UDTF 'FeatureParseUDTF1': java.lang.IllegalStateException: Should not be called directly
> Please make sure your function overrides public StructObjectInspector initialize(ObjectInspector[] args).; line 1 pos 7
This pr will resolve the exception.
### Why are the changes needed?
For the migration of Hive to Spark SQL，we face many UDTF functions throw exception because this issue，It’s really a great improvement for attracting users to Spark SQL.
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
manual
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741771759
@southernriver Could you make pr against master branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-752623026
@southernriver Any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #30665:
URL: https://github.com/apache/spark/pull/30665#discussion_r539310311
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2132,11 +2132,9 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton {
|AS 'org.apache.spark.sql.hive.execution.UDTFStack2'
|USING JAR '${hiveContext.getHiveFile("SPARK-21101-1.0.jar").toURI}'
""".stripMargin)
- val e = intercept[org.apache.spark.sql.AnalysisException] {
- sql("SELECT udtf_stack2(2, 'A', 10, date '2015-01-01', 'B', 20, date '2016-01-01')")
- }
- assert(
- e.getMessage.contains("public StructObjectInspector initialize(ObjectInspector[] args)"))
+ val num =
+ sql("SELECT udtf_stack2(2, 'A', 10, date '2015-01-01', 'B', 20, date '2016-01-01')").count()
+ assert(num === 2)
Review comment:
How about?
```scala
checkAnswer(
sql("SELECT udtf_stack2(2, 'A', 10, date '2015-01-01', 'B', 20, date '2016-01-01')"),
Seq(Row("A", 10, java.sql.Date.valueOf("2015-01-01")),
Row("B", 20, java.sql.Date.valueOf("2016-01-01"))))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-740441515
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #30665:
URL: https://github.com/apache/spark/pull/30665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] southernriver commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
southernriver commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-742194841
@wangyum Thanks a lot, that's good catch. I'll do some fix according to your suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #30665:
URL: https://github.com/apache/spark/pull/30665#discussion_r539308795
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
##########
@@ -91,8 +91,18 @@ private[sql] class HiveSessionCatalog(
isUDAFBridgeRequired = true))
udfExpr.get.dataType // Force it to check input data types.
} else if (classOf[GenericUDTF].isAssignableFrom(clazz)) {
- udfExpr = Some(HiveGenericUDTF(name, new HiveFunctionWrapper(clazz.getName), input))
- udfExpr.get.asInstanceOf[HiveGenericUDTF].elementSchema // Force it to check data types.
+ try {
+ udfExpr = Some(HiveGenericUDTF(name, new HiveFunctionWrapper(clazz.getName), input))
+ // Force it to check input data types.
+ udfExpr.get.asInstanceOf[HiveGenericUDTF].elementSchema
+ } catch {
+ case exception: Exception =>
+ logInfo(s"HiveGenericUDTF initialize(ObjectInspector[] args) is deprecated, and" +
+ s" we will suit the latest version of initialize(StructObjectInspector argOIs).")
+ udfExpr = Some(HiveGenericUDTF(name, new HiveFunctionWrapper(clazz.getName),
+ input, false))
+ udfExpr.get.asInstanceOf[HiveGenericUDTF].elementSchema
Review comment:
How about?
```scala
val funcWrapper = new HiveFunctionWrapper(clazz.getName)
try {
udfExpr = Some(HiveGenericUDTF(name, funcWrapper, input, true))
// Force it to check data types.
udfExpr.get.asInstanceOf[HiveGenericUDTF].elementSchema
} catch {
case e: IllegalStateException if e.getMessage.equals("Should not be called directly") =>
logInfo("Fallback to use the non deprecated UDTF constructor.")
udfExpr = Some(HiveGenericUDTF(name, funcWrapper, input, false))
// Force it to check data types.
udfExpr.get.asInstanceOf[HiveGenericUDTF].elementSchema
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #30665:
URL: https://github.com/apache/spark/pull/30665#discussion_r550304285
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
##########
@@ -91,8 +91,18 @@ private[sql] class HiveSessionCatalog(
isUDAFBridgeRequired = true))
udfExpr.get.dataType // Force it to check input data types.
} else if (classOf[GenericUDTF].isAssignableFrom(clazz)) {
- udfExpr = Some(HiveGenericUDTF(name, new HiveFunctionWrapper(clazz.getName), input))
- udfExpr.get.asInstanceOf[HiveGenericUDTF].elementSchema // Force it to check data types.
+ try {
+ udfExpr = Some(HiveGenericUDTF(name, new HiveFunctionWrapper(clazz.getName), input))
+ // Force it to check input data types.
+ udfExpr.get.asInstanceOf[HiveGenericUDTF].elementSchema
+ } catch {
+ case exception: Exception =>
Review comment:
why do we need this fallback mechanism? can we just switch to the new API without the `deprecated` flag?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741640287
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37082/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741655171
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37082/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741626679
cc @wangyum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #30665:
URL: https://github.com/apache/spark/pull/30665#discussion_r539310892
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2132,11 +2132,9 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton {
|AS 'org.apache.spark.sql.hive.execution.UDTFStack2'
|USING JAR '${hiveContext.getHiveFile("SPARK-21101-1.0.jar").toURI}'
""".stripMargin)
- val e = intercept[org.apache.spark.sql.AnalysisException] {
- sql("SELECT udtf_stack2(2, 'A', 10, date '2015-01-01', 'B', 20, date '2016-01-01')")
- }
- assert(
- e.getMessage.contains("public StructObjectInspector initialize(ObjectInspector[] args)"))
+ val num =
+ sql("SELECT udtf_stack2(2, 'A', 10, date '2015-01-01', 'B', 20, date '2016-01-01')").count()
+ assert(num === 2)
Review comment:
Could you update test name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741628364
**[Test build #132480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132480/testReport)** for PR 30665 at commit [`0e3dca1`](https://github.com/apache/spark/commit/0e3dca1ea3228747a43d573075bc6162cc76d475).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741717794
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132480/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #30665:
URL: https://github.com/apache/spark/pull/30665#discussion_r539309206
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
##########
@@ -198,7 +198,8 @@ private[hive] case class HiveGenericUDF(
private[hive] case class HiveGenericUDTF(
name: String,
funcWrapper: HiveFunctionWrapper,
- children: Seq[Expression])
+ children: Seq[Expression],
+ deprecated: Boolean = true)
Review comment:
`deprecated: Boolean = true` -> `isDeprecatedConstructor: Boolean`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741628364
**[Test build #132480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132480/testReport)** for PR 30665 at commit [`0e3dca1`](https://github.com/apache/spark/commit/0e3dca1ea3228747a43d573075bc6162cc76d475).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741712363
**[Test build #132480 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132480/testReport)** for PR 30665 at commit [`0e3dca1`](https://github.com/apache/spark/commit/0e3dca1ea3228747a43d573075bc6162cc76d475).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #30665:
URL: https://github.com/apache/spark/pull/30665#discussion_r539309795
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala
##########
@@ -212,7 +213,19 @@ private[hive] case class HiveGenericUDTF(
protected lazy val inputInspectors = children.map(toInspector)
@transient
- protected lazy val outputInspector = function.initialize(inputInspectors.toArray)
+ protected lazy val inpuColNames = children.map(_ => "field_name").asJava
+
+ @transient
+ protected lazy val rowOI = ObjectInspectorFactory.getStandardStructObjectInspector(
+ inpuColNames, inputInspectors.asJava)
+
+ @transient
+ protected lazy val outputInspector =
+ if (deprecated) {
+ function.initialize(inputInspectors.toArray)
+ } else {
+ function.initialize(rowOI)
+ }
Review comment:
How about?
```scala
protected lazy val outputInspector = {
if (isDeprecatedConstructor) {
function.initialize(inputInspectors.toArray)
} else {
val rowOI = ObjectInspectorFactory.getStandardStructObjectInspector(
children.zipWithIndex.map(e => s"_col${e._2}").asJava, inputInspectors.asJava)
function.initialize(rowOI)
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741648424
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37082/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-753251029
@southernriver is busy these days. Let's close this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741717794
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132480/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741655171
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37082/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-740441515
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30665: [SPARK-33704][SQL] Support latest version of initialize() in HiveGenericUDTF
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30665:
URL: https://github.com/apache/spark/pull/30665#issuecomment-741626835
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org