[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33994: [SPARK-36753][SQL] ArrayExcept handle duplicated Double.NaN and Float.NaN

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #33994:
URL: https://github.com/apache/spark/pull/33994#discussion_r708571904



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -4094,9 +4100,16 @@ case class ArrayExcept(left: Expression, right: Expression) extends ArrayBinaryL
             }
           } else {
             val elem = array1.get(i, elementType)
-            if (!hs.contains(elem)) {
-              arrayBuffer += elem
-              hs.add(elem)
+            if (isNaN(elem)) {
+              if (notFoundNaNElement) {
+                arrayBuffer += elem

Review comment:
       For this, let's wait a little bit for the decision at the first PR.
   - https://github.com/apache/spark/pull/33955/files#r708570515




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org