You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/10/06 15:40:02 UTC

[GitHub] [hadoop] pjfanning commented on pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

pjfanning commented on PR #4940:
URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1270290164

   > thanks, happy with the explanation.
   > 
   > I'm +1 for the change. there is one suggestion, use AbstractHadoopTestBase, but its not a blocker for this patch. if you don't want to do that, say so and i will merge as is.
   
   @steveloughran I fixed the formatting issue and the build passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org