You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/06 19:54:00 UTC
[GitHub] [hadoop-ozone] nandakumar131 opened a new pull request #776: scmcli
container info command shows the wrong container state.
nandakumar131 opened a new pull request #776: scmcli container info command shows the wrong container state.
URL: https://github.com/apache/hadoop-ozone/pull/776
## What changes were proposed in this pull request?
Container State from SCM is displayed in output of `scmcli container info` command
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3348
## How was this patch tested?
The output was manually checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request
#776: HDDS-3348. scmcli container info command shows the wrong container
state.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on a change in pull request #776: HDDS-3348. scmcli container info command shows the wrong container state.
URL: https://github.com/apache/hadoop-ozone/pull/776#discussion_r404394084
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
##########
@@ -57,26 +55,13 @@
@Override
public Void call() throws Exception {
try (ScmClient scmClient = parent.getParent().createScmClient()) {
- ContainerWithPipeline container = scmClient.
+ final ContainerWithPipeline container = scmClient.
getContainerWithPipeline(containerID);
Preconditions.checkNotNull(container, "Container cannot be null");
- ContainerDataProto containerData = scmClient.readContainer(container
- .getContainerInfo().getContainerID(), container.getPipeline());
-
// Print container report info.
LOG.info("Container id: {}", containerID);
- String openStatus =
- containerData.getState() == ContainerDataProto.State.OPEN ? "OPEN" :
- "CLOSED";
- LOG.info("Container State: {}", openStatus);
- LOG.info("Container Path: {}", containerData.getContainerPath());
-
- // Output meta data.
Review comment:
We don't want this extra information about 'ContainerPath' & 'Datanodes' anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] nandakumar131 merged pull request #776: HDDS-3348.
scmcli container info command shows the wrong container state.
Posted by GitBox <gi...@apache.org>.
nandakumar131 merged pull request #776: HDDS-3348. scmcli container info command shows the wrong container state.
URL: https://github.com/apache/hadoop-ozone/pull/776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] nandakumar131 commented on a change in pull request
#776: HDDS-3348. scmcli container info command shows the wrong container
state.
Posted by GitBox <gi...@apache.org>.
nandakumar131 commented on a change in pull request #776: HDDS-3348. scmcli container info command shows the wrong container state.
URL: https://github.com/apache/hadoop-ozone/pull/776#discussion_r404748859
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
##########
@@ -57,26 +55,13 @@
@Override
public Void call() throws Exception {
try (ScmClient scmClient = parent.getParent().createScmClient()) {
- ContainerWithPipeline container = scmClient.
+ final ContainerWithPipeline container = scmClient.
getContainerWithPipeline(containerID);
Preconditions.checkNotNull(container, "Container cannot be null");
- ContainerDataProto containerData = scmClient.readContainer(container
- .getContainerInfo().getContainerID(), container.getPipeline());
-
// Print container report info.
LOG.info("Container id: {}", containerID);
- String openStatus =
- containerData.getState() == ContainerDataProto.State.OPEN ? "OPEN" :
- "CLOSED";
- LOG.info("Container State: {}", openStatus);
- LOG.info("Container Path: {}", containerData.getContainerPath());
-
- // Output meta data.
Review comment:
We were printing the container path from one of the datanode, this could be misleading if datanodes are configured with a different path for the data directory. It's better to not print the container path in this context.
Printing Datanodes are not removed, it's still printed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request
#776: HDDS-3348. scmcli container info command shows the wrong container
state.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #776: HDDS-3348. scmcli container info command shows the wrong container state.
URL: https://github.com/apache/hadoop-ozone/pull/776#discussion_r404525716
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java
##########
@@ -57,26 +55,13 @@
@Override
public Void call() throws Exception {
try (ScmClient scmClient = parent.getParent().createScmClient()) {
- ContainerWithPipeline container = scmClient.
+ final ContainerWithPipeline container = scmClient.
Review comment:
Print pipeline information of the container will be useful, can we add that info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org