You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2016/11/17 17:34:53 UTC

[Bug 60388] New: --disable-maintainer-mode enables the maintainer mode

https://bz.apache.org/bugzilla/show_bug.cgi?id=60388

            Bug ID: 60388
           Summary: --disable-maintainer-mode enables the maintainer mode
           Product: Tomcat Native
           Version: 1.2.10
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Library
          Assignee: dev@tomcat.apache.org
          Reporter: ebourg@apache.org
  Target Milestone: ---

The maintainer-mode feature in native/configure.in is coded such that only the
presence of the parameter is checked and not its actual value. This results in
the debug mode being enabled when --disable-maintainer-mode or
--enable-maintainer-mode=no is specified.

Here is a suggested fix:


--- a/native/configure.in
+++ b/native/configure.in
@@ -198,12 +198,16 @@
 maintainer-mode,
 [  --enable-maintainer-mode   Turn on debugging and compile time warnings],
 [
-  if test "$GCC" = "yes"; then
-    CFLAGS="${CFLAGS} -DDEBUG -Wall"
-  else
-    CFLAGS="${CFLAGS} -DDEBUG"
-  fi
-AC_MSG_RESULT([...Enabling Maintainer mode...])
+  case "${enableval}" in
+    yes )
+       if test "$GCC" = "yes"; then
+         CFLAGS="${CFLAGS} -DDEBUG -Wall"
+       else
+         CFLAGS="${CFLAGS} -DDEBUG"
+       fi
+       AC_MSG_RESULT([...Enabling Maintainer mode...])
+       ;;
+  esac
 ])

 dnl

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 60388] --disable-maintainer-mode enables the maintainer mode

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60388

Emmanuel Bourg <eb...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Emmanuel Bourg <eb...@apache.org> ---
Fixed in tomcat-native 1.2.11

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org