You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/05/31 01:09:30 UTC

Review Request: Refactored Reaper with an abstraction that hides the dispatching syntax.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11552/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

Rebased against master. Previous review received "shipit"s but got lost.


Diffs
-----

  src/slave/cgroups_isolator.hpp 7b8270d0b0f94a71da12bc123d39b44c40c3f7ed 
  src/slave/cgroups_isolator.cpp 9b3a3a5dfec27a119fdd47a88f016e21470eb88d 
  src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 
  src/slave/process_isolator.cpp d4f7b7603452e7226189899aca7e3c94e537829f 
  src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 
  src/slave/reaper.cpp 1d826d1b5fe1048b03662a1e9d12b18371e5c88f 
  src/tests/reaper_tests.cpp fbb6066652c0f36c0a8fd9b0c4dac7e0240a5210 

Diff: https://reviews.apache.org/r/11552/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Re: Review Request: Refactored Reaper with an abstraction that hides the dispatching syntax.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11552/#review21252
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On May 30, 2013, 11:09 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11552/
> -----------------------------------------------------------
> 
> (Updated May 30, 2013, 11:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> Rebased against master. Previous review received "shipit"s but got lost.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolator.hpp 7b8270d0b0f94a71da12bc123d39b44c40c3f7ed 
>   src/slave/cgroups_isolator.cpp 9b3a3a5dfec27a119fdd47a88f016e21470eb88d 
>   src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 
>   src/slave/process_isolator.cpp d4f7b7603452e7226189899aca7e3c94e537829f 
>   src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 
>   src/slave/reaper.cpp 1d826d1b5fe1048b03662a1e9d12b18371e5c88f 
>   src/tests/reaper_tests.cpp fbb6066652c0f36c0a8fd9b0c4dac7e0240a5210 
> 
> Diff: https://reviews.apache.org/r/11552/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>