[jira] Commented: (MYFACES-443) javax.faces.render.Renderer.encodeChildren() should encode children

["Martin Marinschek (JIRA)" <de...@myfaces.apache.org>]

    [ http://issues.apache.org/jira/browse/MYFACES-443?page=comments#action_12357771 ] 

Martin Marinschek commented on MYFACES-443:
-------------------------------------------

Bruno, I'd never...

thanks for fixing this - and I am reassigning to you.

> javax.faces.render.Renderer.encodeChildren() should encode children
> -------------------------------------------------------------------
>
>          Key: MYFACES-443
>          URL: http://issues.apache.org/jira/browse/MYFACES-443
>      Project: MyFaces
>         Type: Bug
>   Components: Implementation
>     Versions: 1.0.9m9
>     Reporter: Ken Weiner
>     Assignee: Martin Marinschek
>      Fix For: Nightly

>
> I noticed a difference in behavior between MyFaces and the Sun RI in javax.faces.render.Renderer.encodeChildren().  The RI iterates though the children and renders them in succession whereas MyFaces simply asserts that the method arguments are non-null and returns, leaving the optional rendering of the children to the subclasses of Renderer.  I am not 100% sure which behavior is correct, but it seems like the spec, in section 8.2 and 3.1.12, indicates that the encodeChildren() method should do the work of creating the response data for each child. 
> As things are now, there is the potential that someone using the RI could develop a renderer that doesn't override encodeChildren(), expecting the children of his/her component to render.  When this person switches to MyFaces, his/her component will not render its children anymore.
> This discussion on the MyFaces Users mailing list led to me submitting this as an issue:
> http://www.mail-archive.com/users%40myfaces.apache.org/msg07461.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira