You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/15 19:21:06 UTC
Review Request 66097: Adapted the new `grpcpp` C++ headers for gRPC
v1.10 in Mesos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66097/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-8678
https://issues.apache.org/jira/browse/MESOS-8678
Repository: mesos
Description
-------
Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos.
Diffs
-----
configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507
src/examples/test_csi_plugin.cpp 0f65c401bde8e32eea8f63f4bde829e3cff50a74
src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268
Diff: https://reviews.apache.org/r/66097/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for
gRPC v1.10 in Mesos.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66097/
-----------------------------------------------------------
(Updated March 20, 2018, 8:47 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Addressed Ben's comment.
Bugs: MESOS-8678
https://issues.apache.org/jira/browse/MESOS-8678
Repository: mesos
Description (updated)
-------
This patch replaces the use of headers in `grpc++/`, which are
deprecated in upstream gRPC releases, with the new headers in `grpcpp/`.
There is no functional change between these headers.
Diffs
-----
configure.ac f3d11696240bbc0420c92792780c3658993456f1
src/examples/test_csi_plugin.cpp 0f65c401bde8e32eea8f63f4bde829e3cff50a74
src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268
Diff: https://reviews.apache.org/r/66097/diff/2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for
gRPC v1.10 in Mesos.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66097/#review199287
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66094.
Failed command: `python.exe .\support\apply-reviews.py -n -r 66094`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66097
Relevant logs:
- [apply-review-66094-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66097/logs/apply-review-66094-stdout.log):
```
error: missing binary patch data for '3rdparty/grpc-1.10.0.tar.gz'
error: binary patch does not apply to '3rdparty/grpc-1.10.0.tar.gz'
error: 3rdparty/grpc-1.10.0.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On March 15, 2018, 7:21 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66097/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 7:21 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8678
> https://issues.apache.org/jira/browse/MESOS-8678
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos.
>
>
> Diffs
> -----
>
> configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507
> src/examples/test_csi_plugin.cpp 0f65c401bde8e32eea8f63f4bde829e3cff50a74
> src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268
>
>
> Diff: https://reviews.apache.org/r/66097/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for
gRPC v1.10 in Mesos.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66097/#review199296
-----------------------------------------------------------
Bad patch!
Reviews applied: [66097, 66096, 66095, 66094]
Failed command: python support/apply-reviews.py -n -r 66094
Error:
2018-03-15 22:09:56 URL:https://reviews.apache.org/r/66094/diff/raw/ [9043/9043] -> "66094.patch" [1]
error: missing binary patch data for '3rdparty/grpc-1.10.0.tar.gz'
error: binary patch does not apply to '3rdparty/grpc-1.10.0.tar.gz'
error: 3rdparty/grpc-1.10.0.tar.gz: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/21924/console
- Mesos Reviewbot
On March 15, 2018, 7:21 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66097/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 7:21 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8678
> https://issues.apache.org/jira/browse/MESOS-8678
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos.
>
>
> Diffs
> -----
>
> configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507
> src/examples/test_csi_plugin.cpp 0f65c401bde8e32eea8f63f4bde829e3cff50a74
> src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268
>
>
> Diff: https://reviews.apache.org/r/66097/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66097: Adapted the new `grpcpp` C++ headers for
gRPC v1.10 in Mesos.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66097/#review199551
-----------------------------------------------------------
Ship it!
Looking good. Surprised they didn't provide another name for the library as well.
Could you expand the commit message a little to call out that this patch moves us off headers deprecated by upstream and we do not expect any functional changes?
- Benjamin Bannier
On March 15, 2018, 8:21 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66097/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 8:21 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8678
> https://issues.apache.org/jira/browse/MESOS-8678
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adapted the new `grpcpp` C++ headers for gRPC v1.10 in Mesos.
>
>
> Diffs
> -----
>
> configure.ac f3d11696240bbc0420c92792780c3658993456f1
> src/examples/test_csi_plugin.cpp 0f65c401bde8e32eea8f63f4bde829e3cff50a74
> src/tests/mock_csi_plugin.hpp c1a96973574628a261b3d727c764cd0de10a5268
>
>
> Diff: https://reviews.apache.org/r/66097/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>