You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/14 10:23:53 UTC

[GitHub] [flink] xintongsong commented on a diff in pull request #20910: [FLINK-29435]SecurityConfiguration supports dynamic configuration

xintongsong commented on code in PR #20910:
URL: https://github.com/apache/flink/pull/20910#discussion_r995599982


##########
flink-clients/src/main/java/org/apache/flink/client/cli/DynamicPropertiesUtil.java:
##########
@@ -49,7 +49,7 @@ class DynamicPropertiesUtil {
      * Parses dynamic properties from the given {@link CommandLine} and sets them on the {@link
      * Configuration}.
      */
-    static void encodeDynamicProperties(
+    static Configuration encodeDynamicProperties(

Review Comment:
   I think we don't need this change. The dynamic properties are parsed and inserted to the configuration passed-in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org