You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "leaves12138 (via GitHub)" <gi...@apache.org> on 2025/04/03 05:44:24 UTC
[PR] [bug] As for TimeTravel, if the expected timestamp is earlier than the ealiest snapshot, return null [paimon]
leaves12138 opened a new pull request, #5396:
URL: https://github.com/apache/paimon/pull/5396
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Return null if time travel meet earlier timestamp than the earliest snapshot timestamp.
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bug] As for TimeTravel, if the expected timestamp is earlier than the ealiest snapshot, add one parameter to decide to return null or not [paimon]
Posted by "yunfengzhou-hub (via GitHub)" <gi...@apache.org>.
yunfengzhou-hub commented on code in PR #5396:
URL: https://github.com/apache/paimon/pull/5396#discussion_r2026253495
##########
paimon-core/src/main/java/org/apache/paimon/table/source/snapshot/TimeTravelUtil.java:
##########
@@ -146,7 +146,8 @@ private static Snapshot resolveSnapshotByTagName(
SnapshotManager snapshotManager,
ChangelogManager changelogManager,
long timestampMills,
- boolean startFromChangelog) {
+ boolean startFromChangelog,
+ boolean returnNullIfTooEarly) {
Review Comment:
The value of this parameter seems always false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] As for `TimeTravel`, if the expected timestamp is earlier than the earliest snapshot, add one parameter to decide to return null or not [paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 merged PR #5396:
URL: https://github.com/apache/paimon/pull/5396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bug] As for TimeTravel, if the expected timestamp is earlier than the ealiest snapshot, add one parameter to decide to return null or not [paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 closed pull request #5396: [bug] As for TimeTravel, if the expected timestamp is earlier than the ealiest snapshot, add one parameter to decide to return null or not
URL: https://github.com/apache/paimon/pull/5396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bug] As for TimeTravel, if the expected timestamp is earlier than the ealiest snapshot, add one parameter to decide to return null or not [paimon]
Posted by "yunfengzhou-hub (via GitHub)" <gi...@apache.org>.
yunfengzhou-hub commented on code in PR #5396:
URL: https://github.com/apache/paimon/pull/5396#discussion_r2026253495
##########
paimon-core/src/main/java/org/apache/paimon/table/source/snapshot/TimeTravelUtil.java:
##########
@@ -146,7 +146,8 @@ private static Snapshot resolveSnapshotByTagName(
SnapshotManager snapshotManager,
ChangelogManager changelogManager,
long timestampMills,
- boolean startFromChangelog) {
+ boolean startFromChangelog,
+ boolean returnNullIfTooEarly) {
Review Comment:
The value of this parameter seems always false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bug] As for TimeTravel, if the expected timestamp is earlier than the ealiest snapshot, add one parameter to decide to return null or not [paimon]
Posted by "yunfengzhou-hub (via GitHub)" <gi...@apache.org>.
yunfengzhou-hub commented on PR #5396:
URL: https://github.com/apache/paimon/pull/5396#issuecomment-2774960326
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org