You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2021/09/15 00:25:22 UTC

[spark] branch master updated: [SPARK-34943][BUILD] Upgrade flake8 to 3.8.0 or above in Jenkins

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 3e5d3d1  [SPARK-34943][BUILD] Upgrade flake8 to 3.8.0 or above in Jenkins
3e5d3d1 is described below

commit 3e5d3d1cfe9c66f9bb729ecd82299c5242b1b01b
Author: Kevin Su <pi...@gmail.com>
AuthorDate: Wed Sep 15 09:24:50 2021 +0900

    [SPARK-34943][BUILD] Upgrade flake8 to 3.8.0 or above in Jenkins
    
    ### What changes were proposed in this pull request?
    
    Upgrade flake8 to 3.8.0 or above in Jenkins
    
    ### Why are the changes needed?
    
    In flake8 < 3.8.0, F401 error occurs for imports in if statements when TYPE_CHECKING is True. However, TYPE_CHECKING is always False at runtime, so there is no need to treat it as an error in static analysis.
    
    Since this behavior is fixed In flake8 >= 3.8.0, we should upgrade the flake8 installed in Jenkins to 3.8.0 or above. Otherwise, it occurs F401 error for several lines in pandas-on-PySpark that use TYPE_CHECKING
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    Pass the CI
    
    Closes #32749 from pingsutw/SPARK-34943.
    
    Lead-authored-by: Kevin Su <pi...@gmail.com>
    Co-authored-by: Hyukjin Kwon <gu...@gmail.com>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 dev/lint-python | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dev/lint-python b/dev/lint-python
index e54e391..72438f7 100755
--- a/dev/lint-python
+++ b/dev/lint-python
@@ -18,7 +18,7 @@
 # define test binaries + versions
 FLAKE8_BUILD="flake8"
 # TODO(SPARK-34943): minimum version should be 3.8+
-MINIMUM_FLAKE8="3.5.0"
+MINIMUM_FLAKE8="3.8.0"
 MINIMUM_MYPY="0.910"
 MYPY_BUILD="mypy"
 PYCODESTYLE_BUILD="pycodestyle"

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org