You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2013/11/27 21:38:02 UTC
Re: svn commit: r1546114 - in /subversion/trunk: ./
subversion/libsvn_fs_x/ subversion/svnadmin/svnadmin.c
subversion/tests/cmdline/svnadmin_tests.py
subversion/tests/libsvn_fs_x/
stsp@apache.org wrote on Wed, Nov 27, 2013 at 17:08:02 -0000:
> @@ -1696,15 +1741,63 @@ subcommand_verify(apr_getopt_t *os, void
> + /* Show the --keep-going error summary. */
> + if (opt_state->keep_going && notify_baton.error_summary->nelts > 0)
> + {
> + apr_pool_t *iterpool;
> + int i;
> +
> + svn_error_clear(
> + svn_stream_printf(notify_baton.feedback_stream, pool,
> + _("\n-----Summary of corrupt revisions-----\n")));
What happens if the localized string contains a percent sign?
Re: svn commit: r1546114 - in /subversion/trunk: ./
subversion/libsvn_fs_x/ subversion/svnadmin/svnadmin.c
subversion/tests/cmdline/svnadmin_tests.py subversion/tests/libsvn_fs_x/
Posted by Stefan Sperling <st...@elego.de>.
On Wed, Nov 27, 2013 at 10:38:02PM +0200, Daniel Shahaf wrote:
> stsp@apache.org wrote on Wed, Nov 27, 2013 at 17:08:02 -0000:
> > @@ -1696,15 +1741,63 @@ subcommand_verify(apr_getopt_t *os, void
> > + /* Show the --keep-going error summary. */
> > + if (opt_state->keep_going && notify_baton.error_summary->nelts > 0)
> > + {
> > + apr_pool_t *iterpool;
> > + int i;
> > +
> > + svn_error_clear(
> > + svn_stream_printf(notify_baton.feedback_stream, pool,
> > + _("\n-----Summary of corrupt revisions-----\n")));
>
> What happens if the localized string contains a percent sign?
Fixed in r1546191.
Re: svn commit: r1546114 - in /subversion/trunk: ./
subversion/libsvn_fs_x/ subversion/svnadmin/svnadmin.c
subversion/tests/cmdline/svnadmin_tests.py subversion/tests/libsvn_fs_x/
Posted by Stefan Sperling <st...@elego.de>.
On Wed, Nov 27, 2013 at 10:38:02PM +0200, Daniel Shahaf wrote:
> stsp@apache.org wrote on Wed, Nov 27, 2013 at 17:08:02 -0000:
> > @@ -1696,15 +1741,63 @@ subcommand_verify(apr_getopt_t *os, void
> > + /* Show the --keep-going error summary. */
> > + if (opt_state->keep_going && notify_baton.error_summary->nelts > 0)
> > + {
> > + apr_pool_t *iterpool;
> > + int i;
> > +
> > + svn_error_clear(
> > + svn_stream_printf(notify_baton.feedback_stream, pool,
> > + _("\n-----Summary of corrupt revisions-----\n")));
>
> What happens if the localized string contains a percent sign?
Fixed in r1546191.