You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/08/10 14:49:57 UTC

Review Request 13472: make apache server listen on all the ipaliases to provide access to meta-data.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13472/
-----------------------------------------------------------

Review request for cloudstack, Chiradeep Vittal and Sheng Yang.


Bugs: Cloudstack-4231


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-4231
make apache server listen on all the ipaliases to provide access to meta-data.

Earlier we were using the name data-server to access the meta-data in case of multiple subnets. 
This requires updating the guest templates. 

Now we make apache server listen on all the ipaliases. So no need to update the template.
we create separate file for each ipAlias 


Diffs
-----

  patches/systemvm/debian/config/etc/init.d/cloud-early-config a552d44 
  patches/systemvm/debian/config/root/createIpAlias.sh 5498195 
  patches/systemvm/debian/config/root/deleteIpAlias.sh fa228fb 

Diff: https://reviews.apache.org/r/13472/diff/


Testing
-------

Tested on 4.2


Thanks,

bharat kumar


Re: Review Request 13472: make apache server listen on all the ipaliases to provide access to meta-data.

Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13472/#review25001
-----------------------------------------------------------

Ship it!


Ship It!

- Jayapal Reddy


On Aug. 12, 2013, 10:42 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13472/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 10:42 a.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal, Jayapal Reddy, Murali Reddy, and Sheng Yang.
> 
> 
> Bugs: Cloudstack-4231
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-4231
> make apache server listen on all the ipaliases to provide access to meta-data.
> 
> Earlier we were using the name data-server to access the meta-data in case of multiple subnets. 
> This requires updating the guest templates. 
> 
> Now we make apache server listen on all the ipaliases. So no need to update the template.
> we create separate file for each ipAlias 
> 
> 
> Diffs
> -----
> 
>   patches/systemvm/debian/config/etc/init.d/cloud-early-config a552d44 
>   patches/systemvm/debian/config/root/createIpAlias.sh 5498195 
>   patches/systemvm/debian/config/root/deleteIpAlias.sh fa228fb 
> 
> Diff: https://reviews.apache.org/r/13472/diff/
> 
> 
> Testing
> -------
> 
> Tested on 4.2
> deployed vms in different subnets.
> used the script cloud-set-guest-sshkey.in to fetch the public keys form the router.
> was able to get the keys without using the name data-server.
> 
> deleted the subnet and checked if the apache config was removed.
> 
> ran a failure case, all the config files generated during this operation were moved to failure_directory.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Re: Review Request 13472: make apache server listen on all the ipaliases to provide access to meta-data.

Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13472/
-----------------------------------------------------------

(Updated Aug. 12, 2013, 10:42 a.m.)


Review request for cloudstack, Chiradeep Vittal, Jayapal Reddy, Murali Reddy, and Sheng Yang.


Changes
-------

Added jayapal


Bugs: Cloudstack-4231


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-4231
make apache server listen on all the ipaliases to provide access to meta-data.

Earlier we were using the name data-server to access the meta-data in case of multiple subnets. 
This requires updating the guest templates. 

Now we make apache server listen on all the ipaliases. So no need to update the template.
we create separate file for each ipAlias 


Diffs
-----

  patches/systemvm/debian/config/etc/init.d/cloud-early-config a552d44 
  patches/systemvm/debian/config/root/createIpAlias.sh 5498195 
  patches/systemvm/debian/config/root/deleteIpAlias.sh fa228fb 

Diff: https://reviews.apache.org/r/13472/diff/


Testing
-------

Tested on 4.2
deployed vms in different subnets.
used the script cloud-set-guest-sshkey.in to fetch the public keys form the router.
was able to get the keys without using the name data-server.

deleted the subnet and checked if the apache config was removed.

ran a failure case, all the config files generated during this operation were moved to failure_directory.


Thanks,

bharat kumar


Re: Review Request 13472: make apache server listen on all the ipaliases to provide access to meta-data.

Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13472/
-----------------------------------------------------------

(Updated Aug. 12, 2013, 10:24 a.m.)


Review request for cloudstack, Chiradeep Vittal, Murali Reddy, and Sheng Yang.


Bugs: Cloudstack-4231


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-4231
make apache server listen on all the ipaliases to provide access to meta-data.

Earlier we were using the name data-server to access the meta-data in case of multiple subnets. 
This requires updating the guest templates. 

Now we make apache server listen on all the ipaliases. So no need to update the template.
we create separate file for each ipAlias 


Diffs (updated)
-----

  patches/systemvm/debian/config/etc/init.d/cloud-early-config a552d44 
  patches/systemvm/debian/config/root/createIpAlias.sh 5498195 
  patches/systemvm/debian/config/root/deleteIpAlias.sh fa228fb 

Diff: https://reviews.apache.org/r/13472/diff/


Testing
-------

Tested on 4.2
deployed vms in different subnets.
used the script cloud-set-guest-sshkey.in to fetch the public keys form the router.
was able to get the keys without using the name data-server.

deleted the subnet and checked if the apache config was removed.

ran a failure case, all the config files generated during this operation were moved to failure_directory.


Thanks,

bharat kumar


Re: Review Request 13472: make apache server listen on all the ipaliases to provide access to meta-data.

Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13472/
-----------------------------------------------------------

(Updated Aug. 12, 2013, 4:37 a.m.)


Review request for cloudstack, Chiradeep Vittal, Murali Reddy, and Sheng Yang.


Changes
-------

Adding Murali to the review request.


Bugs: Cloudstack-4231


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-4231
make apache server listen on all the ipaliases to provide access to meta-data.

Earlier we were using the name data-server to access the meta-data in case of multiple subnets. 
This requires updating the guest templates. 

Now we make apache server listen on all the ipaliases. So no need to update the template.
we create separate file for each ipAlias 


Diffs
-----

  patches/systemvm/debian/config/etc/init.d/cloud-early-config a552d44 
  patches/systemvm/debian/config/root/createIpAlias.sh 5498195 
  patches/systemvm/debian/config/root/deleteIpAlias.sh fa228fb 

Diff: https://reviews.apache.org/r/13472/diff/


Testing
-------

Tested on 4.2
deployed vms in different subnets.
used the script cloud-set-guest-sshkey.in to fetch the public keys form the router.
was able to get the keys without using the name data-server.

deleted the subnet and checked if the apache config was removed.

ran a failure case, all the config files generated during this operation were moved to failure_directory.


Thanks,

bharat kumar


Re: Review Request 13472: make apache server listen on all the ipaliases to provide access to meta-data.

Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13472/
-----------------------------------------------------------

(Updated Aug. 10, 2013, 1:31 p.m.)


Review request for cloudstack, Chiradeep Vittal and Sheng Yang.


Changes
-------

updating the tests conducted.


Bugs: Cloudstack-4231


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-4231
make apache server listen on all the ipaliases to provide access to meta-data.

Earlier we were using the name data-server to access the meta-data in case of multiple subnets. 
This requires updating the guest templates. 

Now we make apache server listen on all the ipaliases. So no need to update the template.
we create separate file for each ipAlias 


Diffs
-----

  patches/systemvm/debian/config/etc/init.d/cloud-early-config a552d44 
  patches/systemvm/debian/config/root/createIpAlias.sh 5498195 
  patches/systemvm/debian/config/root/deleteIpAlias.sh fa228fb 

Diff: https://reviews.apache.org/r/13472/diff/


Testing (updated)
-------

Tested on 4.2
deployed vms in different subnets.
used the script cloud-set-guest-sshkey.in to fetch the public keys form the router.
was able to get the keys without using the name data-server.

deleted the subnet and checked if the apache config was removed.

ran a failure case, all the config files generated during this operation were moved to failure_directory.


Thanks,

bharat kumar


Re: Review Request 13472: make apache server listen on all the ipaliases to provide access to meta-data.

Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13472/
-----------------------------------------------------------

(Updated Aug. 10, 2013, 1:25 p.m.)


Review request for cloudstack, Chiradeep Vittal and Sheng Yang.


Changes
-------

Fixed some typos.


Bugs: Cloudstack-4231


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-4231
make apache server listen on all the ipaliases to provide access to meta-data.

Earlier we were using the name data-server to access the meta-data in case of multiple subnets. 
This requires updating the guest templates. 

Now we make apache server listen on all the ipaliases. So no need to update the template.
we create separate file for each ipAlias 


Diffs (updated)
-----

  patches/systemvm/debian/config/etc/init.d/cloud-early-config a552d44 
  patches/systemvm/debian/config/root/createIpAlias.sh 5498195 
  patches/systemvm/debian/config/root/deleteIpAlias.sh fa228fb 

Diff: https://reviews.apache.org/r/13472/diff/


Testing
-------

Tested on 4.2


Thanks,

bharat kumar