You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/29 09:23:39 UTC

[GitHub] [kafka] dajac opened a new pull request #10427: MINOR: Remove deprecated producer/consumer default quota configurations

dajac opened a new pull request #10427:
URL: https://github.com/apache/kafka/pull/10427


   `quota.producer.default` and `quota.consumer.default` were deprecated in AK 0.11.0.0. I propose to remove them in AK 3.0.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10427:
URL: https://github.com/apache/kafka/pull/10427#issuecomment-816790273


   Failed tests are unrelated to this PR. Same tests fail in trunk. I will go ahead and merge this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10427: KAFKA-12577; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10427:
URL: https://github.com/apache/kafka/pull/10427#issuecomment-810020286


   @rajinisivaram @ijuma I propose to remove these two configurations that were deprecated in 0.11. There is a clear alternative which consists in using the default dynamic quotas. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10427:
URL: https://github.com/apache/kafka/pull/10427#issuecomment-816623928


   @rajinisivaram Thanks for your review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10427:
URL: https://github.com/apache/kafka/pull/10427#issuecomment-815270148


   Seems reasonable to me. Any downside for the alternative?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] rajinisivaram commented on pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

Posted by GitBox <gi...@apache.org>.
rajinisivaram commented on pull request #10427:
URL: https://github.com/apache/kafka/pull/10427#issuecomment-816497458


   We decided not to support static quotas for request quotas and left these in for compatibility earlier. It seems ok to remove the static quotas for 3.0 and rely on just the dynamic quotas which can be set at the whole cluster level.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

Posted by GitBox <gi...@apache.org>.
dajac merged pull request #10427:
URL: https://github.com/apache/kafka/pull/10427


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10427: KAFKA-12591; Remove deprecated `quota.producer.default` and `quota.consumer.default` configurations

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10427:
URL: https://github.com/apache/kafka/pull/10427#issuecomment-816624069


   I have rebased the PR to fix the conflict in the upgrade notes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org