You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2022/09/24 12:49:22 UTC

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19040


Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
......................................................................

IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml

IMPALA-11369 should replace all occurrences of THRIFT_HOME with either
of THRIFT_CPP_HOME, THRIFT_JAVA_HOME, or THRIFT_PY_HOME. However, it
miss replacing THRIFT_HOME to THRIFT_JAVA_HOME in fe/pom.xml.

This reference has not cause an issue in compilation so far, but it
should be replaced with the right one. This patch does that replacement.

Testing:
- Run and pass ./buildall.sh -skiptests -notests

Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
---
M fe/pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/19040/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19040 )

Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Sep 2022 13:18:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19040 )

Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 08:06:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19040 )

Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
......................................................................

IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml

IMPALA-11369 should replace all occurrences of THRIFT_HOME with either
of THRIFT_CPP_HOME, THRIFT_JAVA_HOME, or THRIFT_PY_HOME. However, it
miss replacing THRIFT_HOME to THRIFT_JAVA_HOME in fe/pom.xml.

This reference has not cause an issue in compilation so far, but it
should be replaced with the right one. This patch does that replacement.

Testing:
- Run and pass ./buildall.sh -skiptests -notests

Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
Reviewed-on: http://gerrit.cloudera.org:8080/19040
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Wenzhe Zhou: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19040 )

Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8606/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Sep 2022 13:31:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19040 )

Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11429/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Sep 2022 13:09:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19040 )

Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8606/


-- 
To view, visit http://gerrit.cloudera.org:8080/19040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Sep 2022 18:32:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19040 )

Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
......................................................................


Patch Set 1:

Hit by IMPALA-11572


-- 
To view, visit http://gerrit.cloudera.org:8080/19040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Sep 2022 00:17:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19040 )

Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8621/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19040
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39d47375353bb4d98399b5ff765d63aa331f63d
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Sep 2022 02:59:17 +0000
Gerrit-HasComments: No