[GitHub] jonpspri opened a new pull request #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

[GitBox <gi...@apache.org>]

jonpspri opened a new pull request #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes
URL: https://github.com/apache/incubator-openwhisk/pull/3412
 
 
   Changes to ansible processes for determining and maybe pulling runtime images, as a preliminary to eliminating the hardcoding of the 'whisk' prefix for runtime docker images.
   
   ## Description
   As per discussion in #3407 , this PR contains changes to ansible processes that will be needed to support the removal of the need for 'whisk/*' images to be in place for builtin runtimes.  Instead,
   runtimes _may_ (do we eventually want _should_ or _must_?) be specified in the runtimes.json file.
   
   A pleasant side effect of this change is that all variables (I think) impacting runtimes have now been consolidated into the 'runtimes' YAML object in `ansible/group_vars/all`, and all overrides are tested and defaulted at that point.  There my be some redundant defaulting remaining in `ansible/roles/(controller|invoker)/tasks/deploy.yml`, but I'm trying to manage the number of changes and other maintenance risks that may creep in.
   
   Review and PG requested -- there may be breakage in the IBM Functions build.
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [X] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [X] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [X] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [X] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [X] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services