You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Stephen Hoogendijk <st...@tca0.nl> on 2014/08/11 20:06:59 UTC
Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for
security group rules
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24557/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 6:06 p.m.)
Review request for cloudstack, daan Hoogland and Wei Zhou.
Summary (updated)
-----------------
CLOUDSTACK-7308 - Adds tagging support for security group rules
Bugs: CLOUDSTACK-7308
https://issues.apache.org/jira/browse/CLOUDSTACK-7308
Repository: cloudstack-git
Description
-------
Adds tagging support for security group rules.
Diffs
-----
api/src/com/cloud/server/ResourceTag.java d91bb7d
api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java e2d525a
server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 093709d
server/src/com/cloud/api/query/vo/ResourceTagJoinVO.java 2c1ff47
server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c
Diff: https://reviews.apache.org/r/24557/diff/
Testing
-------
api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found.
Thanks,
Stephen Hoogendijk
Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for
security group rules
Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24557/#review50199
-----------------------------------------------------------
server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java
<https://reviews.apache.org/r/24557/#comment87809>
This is not needed.
server/src/com/cloud/api/query/vo/ResourceTagJoinVO.java
<https://reviews.apache.org/r/24557/#comment87807>
This part of change is not needed.
- Wei Zhou
On Aug. 11, 2014, 6:06 p.m., Stephen Hoogendijk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24557/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 6:06 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7308
> https://issues.apache.org/jira/browse/CLOUDSTACK-7308
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adds tagging support for security group rules.
>
>
> Diffs
> -----
>
> api/src/com/cloud/server/ResourceTag.java d91bb7d
> api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java e2d525a
> server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 093709d
> server/src/com/cloud/api/query/vo/ResourceTagJoinVO.java 2c1ff47
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c
>
> Diff: https://reviews.apache.org/r/24557/diff/
>
>
> Testing
> -------
>
> api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found.
>
>
> Thanks,
>
> Stephen Hoogendijk
>
>
Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for
security group rules
Posted by Ilia Shakitko <i....@tech.leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24557/#review50324
-----------------------------------------------------------
Ship it!
Ship It!
- Ilia Shakitko
On Aug. 12, 2014, 7:27 a.m., Stephen Hoogendijk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24557/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 7:27 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7308
> https://issues.apache.org/jira/browse/CLOUDSTACK-7308
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adds tagging support for security group rules.
>
>
> Diffs
> -----
>
> api/src/com/cloud/server/ResourceTag.java d91bb7d
> api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java e2d525a
> server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 093709d
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c
>
> Diff: https://reviews.apache.org/r/24557/diff/
>
>
> Testing
> -------
>
> api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found.
>
>
> Thanks,
>
> Stephen Hoogendijk
>
>
Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for
security group rules
Posted by Stephen Hoogendijk <st...@tca0.nl>.
> On Aug. 12, 2014, 1:19 p.m., daan Hoogland wrote:
> > seems resonable, but why is this for 4.4? In it self it does not provide any functionality. Let's put it in master, alright?
I've changed it to master branch :)
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24557/#review50318
-----------------------------------------------------------
On Aug. 12, 2014, 2:39 p.m., Stephen Hoogendijk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24557/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 2:39 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7308
> https://issues.apache.org/jira/browse/CLOUDSTACK-7308
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adds tagging support for security group rules.
>
>
> Diffs
> -----
>
> api/src/com/cloud/server/ResourceTag.java d91bb7d
> api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java e2d525a
> server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 093709d
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c
>
> Diff: https://reviews.apache.org/r/24557/diff/
>
>
> Testing
> -------
>
> api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found.
>
>
> Thanks,
>
> Stephen Hoogendijk
>
>
Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for
security group rules
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24557/#review50318
-----------------------------------------------------------
seems resonable, but why is this for 4.4? In it self it does not provide any functionality. Let's put it in master, alright?
- daan Hoogland
On Aug. 12, 2014, 7:27 a.m., Stephen Hoogendijk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24557/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 7:27 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7308
> https://issues.apache.org/jira/browse/CLOUDSTACK-7308
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adds tagging support for security group rules.
>
>
> Diffs
> -----
>
> api/src/com/cloud/server/ResourceTag.java d91bb7d
> api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java e2d525a
> server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 093709d
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c
>
> Diff: https://reviews.apache.org/r/24557/diff/
>
>
> Testing
> -------
>
> api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found.
>
>
> Thanks,
>
> Stephen Hoogendijk
>
>
Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for
security group rules
Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24557/#review50707
-----------------------------------------------------------
Ship it!
Ship It!
- Wei Zhou
On 八月 12, 2014, 2:39 p.m., Stephen Hoogendijk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24557/
> -----------------------------------------------------------
>
> (Updated 八月 12, 2014, 2:39 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7308
> https://issues.apache.org/jira/browse/CLOUDSTACK-7308
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adds tagging support for security group rules.
>
>
> Diffs
> -----
>
> api/src/com/cloud/server/ResourceTag.java d91bb7d
> api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java e2d525a
> server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 093709d
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c
>
> Diff: https://reviews.apache.org/r/24557/diff/
>
>
> Testing
> -------
>
> api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found.
>
>
> Thanks,
>
> Stephen Hoogendijk
>
>
Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for
security group rules
Posted by Stephen Hoogendijk <st...@tca0.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24557/#review50438
-----------------------------------------------------------
Ship it!
Ship It!
- Stephen Hoogendijk
On Aug. 12, 2014, 2:39 p.m., Stephen Hoogendijk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24557/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 2:39 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7308
> https://issues.apache.org/jira/browse/CLOUDSTACK-7308
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adds tagging support for security group rules.
>
>
> Diffs
> -----
>
> api/src/com/cloud/server/ResourceTag.java d91bb7d
> api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java e2d525a
> server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 093709d
> server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c
>
> Diff: https://reviews.apache.org/r/24557/diff/
>
>
> Testing
> -------
>
> api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found.
>
>
> Thanks,
>
> Stephen Hoogendijk
>
>
Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for
security group rules
Posted by Stephen Hoogendijk <st...@tca0.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24557/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 2:39 p.m.)
Review request for cloudstack, daan Hoogland and Wei Zhou.
Changes
-------
Changed branch to master
Bugs: CLOUDSTACK-7308
https://issues.apache.org/jira/browse/CLOUDSTACK-7308
Repository: cloudstack-git
Description
-------
Adds tagging support for security group rules.
Diffs
-----
api/src/com/cloud/server/ResourceTag.java d91bb7d
api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java e2d525a
server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 093709d
server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c
Diff: https://reviews.apache.org/r/24557/diff/
Testing
-------
api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found.
Thanks,
Stephen Hoogendijk
Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for
security group rules
Posted by Stephen Hoogendijk <st...@tca0.nl>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24557/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 7:27 a.m.)
Review request for cloudstack, daan Hoogland and Wei Zhou.
Changes
-------
Resolved issues reported by Wei Zhou
Bugs: CLOUDSTACK-7308
https://issues.apache.org/jira/browse/CLOUDSTACK-7308
Repository: cloudstack-git
Description
-------
Adds tagging support for security group rules.
Diffs (updated)
-----
api/src/com/cloud/server/ResourceTag.java d91bb7d
api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java e2d525a
server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 093709d
server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c
Diff: https://reviews.apache.org/r/24557/diff/
Testing
-------
api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found.
Thanks,
Stephen Hoogendijk