Re: Review Request 29110: LENS-24 - Changes to plugin Query Rewriter

[Suma Shivaprasad <su...@gmail.com>]

> On Dec. 30, 2014, 10:50 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java, line 180
> > <https://reviews.apache.org/r/29110/diff/4/?file=803342#file803342line180>
> >
> >     Is this method still required?

It makes sense for it to be part of the DriverContext API and the other convenience method setDriverConf(Configuration) reuses this


> On Dec. 30, 2014, 10:50 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/resources/lensserver-default.xml, line 583
> > <https://reviews.apache.org/r/29110/diff/4/?file=803347#file803347line583>
> >
> >     Shouldn't this be phase1 rewriters only? Why is cube added here?

Cube was added accroding to jaideep's review comment. Makes sense to have default as cube rewriter which could overidden by client in lens-site.xml


- Suma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29110/#review66351
-----------------------------------------------------------


On Dec. 30, 2014, 9:04 a.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29110/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 9:04 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-24
>     https://issues.apache.org/jira/browse/LENS-24
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-24 - Changes to plugin Query Rewriter
> 
> 
> RewriteUtil changes
>  -> had 2 rewrite phases now - rewriteToCubeQL and rewriteToHQL
>  -> rewriteToHQL operates on getRewrittenQuery instead of getUserQuery()
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java d2da97d 
>   lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 796a582 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cd1a0c7 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 9c17749 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java ce62b65 
>   lens-examples/src/main/resources/dim3-storage-tables.xml 213138a 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 0ae539e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java c1d4954 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 5dab13b 
>   lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java 749ef60 
>   lens-server/pom.xml 55d5d58 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9521136 
>   lens-server/src/main/java/org/apache/lens/server/query/RewriteUtil.java PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 986c714 
>   lens-server/src/test/java/org/apache/lens/server/query/DummyQueryRewriter.java PRE-CREATION 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 7edc3bc 
>   lens-server/src/test/java/org/apache/lens/server/query/TestRewriting.java PRE-CREATION 
>   lens-server/src/test/resources/lens-site.xml ebf4ddb 
>   src/site/apt/admin/config.apt e982b07 
> 
> Diff: https://reviews.apache.org/r/29110/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>