[jira] [Commented] (GEODE-6915) Improve CompiledGroupBySelect Integration Test

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912117#comment-16912117 ] 

ASF subversion and git services commented on GEODE-6915:
--------------------------------------------------------

Commit 9368e09898a3f2c2c71d624ee3ef661ef55d34ed in geode's branch refs/heads/develop from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9368e09 ]

GEODE-6915: Improve CompiledGroupBySelect Tests (#3954)

- Refactored the class in favor of the starter rules and utilities.
- Added tests for several combinations of group by clause with other
  aggregate functions, nested queries and aliases.

> Improve CompiledGroupBySelect Integration Test
> ----------------------------------------------
>
>                 Key: GEODE-6915
>                 URL: https://issues.apache.org/jira/browse/GEODE-6915
>             Project: Geode
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Juan José Ramos Cassella
>            Assignee: Juan José Ramos Cassella
>            Priority: Major
>              Labels: GeodeCommons
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The name for {{CompiledGroupBySelectJUnitTest}} implies that the test is a *unit test* but it's not, it's actually an *integration test*: rename the class to {{CompiledGroupBySelectIntegrationTest}} instead. Also, the test only verifies the query compilation for some variations only ({{count}}, {{group by}} and {{max}}), add tests for the remaining aggregate functions.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)