[GitHub] [nifi] bbende commented on a change in pull request #5696: NIFI-9615 Extending capabilities of NAR provider with restraing, conflict resolution strategy and refactors to make it more flexible

[GitBox <gi...@apache.org>]

bbende commented on a change in pull request #5696:
URL: https://github.com/apache/nifi/pull/5696#discussion_r790816414



##########
File path: nifi-api/src/main/java/org/apache/nifi/flow/resource/ExternalResourceProvider.java
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.flow.resource;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.Collection;
+
+/**
+ * Represents an external source where the resource files might be acquired from. These external resources might be
+ * various: database drivers, different kind of configurations and so on.
+ */
+public interface ExternalResourceProvider {

Review comment:
       Something I thought about when implementing the registry provider was that it might been nice if this interface used generics like `T extends ExternalResourceDescriptor` so that the implementations can pass their own object between the list and fetch methods. Currently the assumption is that the location is a String, but for registry it was really several fields that had to be forced into a String representation. It isn't a big deal since the registry implementation is already working, just thought I'd mention it for consideration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org