You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HeartSaVioR (via GitHub)" <gi...@apache.org> on 2023/02/28 03:10:20 UTC
[GitHub] [spark] HeartSaVioR opened a new pull request, #40208: [SPARK-42592][SS][DOCS][FOLLOWUP] Add missed commit on reflecting review comment
HeartSaVioR opened a new pull request, #40208:
URL: https://github.com/apache/spark/pull/40208
### What changes were proposed in this pull request?
This PR addressed missed commit on reflecting review comment (https://github.com/apache/spark/pull/40188#discussion_r1119055652) from previous PR #40188.
### Why are the changes needed?
Previously pushed commit didn't reflect all review comments.
### Does this PR introduce _any_ user-facing change?
Yes, documentation.
### How was this patch tested?
N/A.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #40208: [SPARK-42592][SS][DOCS][FOLLOWUP] Add missed commit on reflecting review comment
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #40208:
URL: https://github.com/apache/spark/pull/40208#issuecomment-1447564499
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #40208: [SPARK-42592][SS][DOCS][FOLLOWUP] Add missed commit on reflecting review comment
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #40208:
URL: https://github.com/apache/spark/pull/40208#issuecomment-1447534680
Thanks! Merging to master/3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR closed pull request #40208: [SPARK-42592][SS][DOCS][FOLLOWUP] Add missed commit on reflecting review comment
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #40208: [SPARK-42592][SS][DOCS][FOLLOWUP] Add missed commit on reflecting review comment
URL: https://github.com/apache/spark/pull/40208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #40208: [SPARK-42592][SS][DOCS][FOLLOWUP] Add missed commit on reflecting review comment
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #40208:
URL: https://github.com/apache/spark/pull/40208#issuecomment-1447506796
cc. @HyukjinKwon @viirya Sorry to bug you but can I get another quick review for this? My bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org