[GitHub] srkukarni commented on a change in pull request #2593: Add support for running python functions with wheel file

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #2593: Add support for running python functions with wheel file
URL: https://github.com/apache/incubator-pulsar/pull/2593#discussion_r218534628
 
 

 ##########
 File path: pulsar-functions/instance/src/main/python/python_instance_main.py
 ##########
 @@ -74,6 +73,15 @@ def main():
   args = parser.parse_args()
   function_details = Function_pb2.FunctionDetails()
   json_format.Parse(args.function_details, function_details)
+
+  if function_details.runtime == Function_pb2.FunctionDetails.Runtime.Value("PYTHON_WHEEL"):
+    try:
+      util.install_wheel(str(args.py))
 
 Review comment:
   I've redone that part with installing using virtualenv to minimize impact on the system and needing permissions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services