You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/03/14 14:22:28 UTC
[GitHub] [incubator-mxnet] piotrwolinski-intel opened a new pull request #20958: [master] Fix issue with fc_eltwise fusing
piotrwolinski-intel opened a new pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958
These changes are introduced to allow more activation functions to be used with fused and quantized fc_eltwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#issuecomment-1070996017
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#issuecomment-1071000736
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#issuecomment-1082745571
@mxnet-bot run ci [unix-cpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#issuecomment-1082745712
Jenkins CI successfully triggered : [windows-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#discussion_r832287930
##########
File path: src/operator/nn/dnnl/dnnl_act.cc
##########
@@ -70,9 +70,9 @@ bool SupportDNNLLeakyRelu(const LeakyReLUParam& param, const NDArray& input) {
}
bool SupportQuantizedDNNLAct(const ActivationParam& param) {
- // TODO(zhennan): Add more activation type when dnnl supports.
- // Remove this when it's identity to SupportDNNLAct.
- return param.act_type == activation::kReLU;
+ // Although it is the same as SupportDNNLAct i left it here, so when new activations
Review comment:
I understand what you mean but would still prefer this removed. I believe that a developer will create separate function for more sophisticated functions if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#issuecomment-1085523305
@mxnet-bot run ci [unix-cpu, centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#issuecomment-1085523388
Jenkins CI successfully triggered : [centos-cpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#issuecomment-1070996017
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#issuecomment-1071000736
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#issuecomment-1084555745
Jenkins CI successfully triggered : [website, unix-gpu, miscellaneous, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] piotrwolinski-intel commented on pull request #20958: [master] Fix issue with fc_eltwise fusing
Posted by GitBox <gi...@apache.org>.
piotrwolinski-intel commented on pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#issuecomment-1084555600
@mxnet-bot run ci [website, unix-gpu, unix-cpu, miscellaneous]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org