You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by li...@apache.org on 2024/08/21 23:48:02 UTC

(arrow-adbc) branch main updated: test(go/adbc/driver/flightsql): more testing of header parameter (#2092)

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new 037f2c68e test(go/adbc/driver/flightsql): more testing of header parameter (#2092)
037f2c68e is described below

commit 037f2c68ee11aa12f5c5fb606d49b47b613fd0b9
Author: David Li <li...@gmail.com>
AuthorDate: Thu Aug 22 08:47:58 2024 +0900

    test(go/adbc/driver/flightsql): more testing of header parameter (#2092)
    
    Do some more thorough testing of the header option to hopefully avoid
    more bugs around this.
---
 go/adbc/driver/flightsql/flightsql_adbc_test.go | 73 +++++++++++++++++++++++++
 1 file changed, 73 insertions(+)

diff --git a/go/adbc/driver/flightsql/flightsql_adbc_test.go b/go/adbc/driver/flightsql/flightsql_adbc_test.go
index 5f34d3410..927c67b03 100644
--- a/go/adbc/driver/flightsql/flightsql_adbc_test.go
+++ b/go/adbc/driver/flightsql/flightsql_adbc_test.go
@@ -36,6 +36,7 @@ import (
 	"os"
 	"path/filepath"
 	"runtime"
+	"slices"
 	"strings"
 	"testing"
 	"time"
@@ -306,6 +307,78 @@ func TestADBCFlightSQL(t *testing.T) {
 	suite.Run(t, &DomainSocketTests{db: db})
 }
 
+// Run the test suite, but validating that a header set on the database is ALWAYS passed
+
+type FlightSQLWithHeaderQuirks struct {
+	FlightSQLQuirks
+}
+
+func (s *FlightSQLWithHeaderQuirks) SetupDriver(t *testing.T) adbc.Driver {
+	var err error
+	s.mem = memory.NewCheckedAllocator(memory.DefaultAllocator)
+	// Enforce that a particular header is present on ALL requests
+	s.s = flight.NewServerWithMiddleware([]flight.ServerMiddleware{
+		{
+			Unary: func(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) {
+				if md, ok := metadata.FromIncomingContext(ctx); ok {
+					vals := md.Get("x-expected")
+					if slices.Contains(vals, "open sesame") {
+						return handler(ctx, req)
+					}
+				}
+				return nil, fmt.Errorf("missing expected header")
+			},
+			Stream: func(srv interface{}, stream grpc.ServerStream, info *grpc.StreamServerInfo, handler grpc.StreamHandler) error {
+				ctx := stream.Context()
+				if md, ok := metadata.FromIncomingContext(ctx); ok {
+					vals := md.Get("x-expected")
+					if slices.Contains(vals, "open sesame") {
+						return handler(srv, stream)
+					}
+				}
+				return fmt.Errorf("missing expected header")
+			},
+		},
+	}, s.opts...)
+	require.NoError(t, err)
+	s.srv, err = example.NewSQLiteFlightSQLServer(s.db)
+	require.NoError(t, err)
+	s.srv.Alloc = s.mem
+
+	s.s.RegisterFlightService(flightsql.NewFlightServer(s.srv))
+	require.NoError(t, s.s.Init("localhost:0"))
+	s.s.SetShutdownOnSignals(os.Interrupt, os.Kill)
+	s.done = make(chan bool)
+	go func() {
+		defer close(s.done)
+		_ = s.s.Serve()
+	}()
+
+	return driver.NewDriver(s.mem)
+}
+
+func (s *FlightSQLWithHeaderQuirks) DatabaseOptions() map[string]string {
+	return map[string]string{
+		adbc.OptionKeyURI: "grpc+tcp://" + s.s.Addr().String(),
+		driver.OptionRPCCallHeaderPrefix + "x-expected": "open sesame",
+	}
+}
+
+func TestADBCFlightSQLWithHeader(t *testing.T) {
+	// XXX: arrow-go uses a shared DB so CreateDB can't be called more than once in a process
+	db, err := sql.Open("sqlite", "file:adbcwithheader?mode=memory&cache=private")
+	require.NoError(t, err)
+	defer db.Close()
+
+	q := &FlightSQLWithHeaderQuirks{FlightSQLQuirks{db: db}}
+	suite.Run(t, &validation.DatabaseTests{Quirks: q})
+	suite.Run(t, &validation.ConnectionTests{Quirks: q})
+	suite.Run(t, &validation.StatementTests{Quirks: q})
+	suite.Run(t, &OptionTests{Quirks: q})
+	suite.Run(t, &PartitionTests{Quirks: q})
+	suite.Run(t, &StatementTests{Quirks: q})
+}
+
 // Driver-specific tests
 
 type DefaultDialOptionsTests struct {