You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "sjvanrossum (via GitHub)" <gi...@apache.org> on 2025/11/17 10:47:30 UTC
[PR] [KafkaIO] Replace end offset consumer with admin client [beam]
sjvanrossum opened a new pull request, #36834:
URL: https://github.com/apache/beam/pull/36834
Continuing from #36075, this PR removes support for old Kafka client libraries, requiring at least Kafka 2.8.2 or newer. Note that every version of Kafka <4.0.0 still supports [API protocol versions <0.10.0](https://kafka.apache.org/41/documentation/compatibility.html#p-compatibility) and the compatibility matrix indicates that versions of Kafka >=3.0.0 would provide the best compatibility in combination with versions of Kafka >=4.0.0.
I've got another change to the poll loop queued up that leverages features only available in versions of Kafka >=3.0.0, so I'll address that compatibility bit in a following PR.
This PR leverages the `Admin` client to request end offsets without creating buffers like `Consumer` clients do. Profiling showed that `Admin` clients used 10% of the memory that was used by `Consumer` clients for end offset requests. The `Admin` client returns a `KafkaFuture` for every request which is fulfilled by an IO thread managed by the Kafka client library, thus restoring the background thread feature that was removed in #36075.
I intend to backport this change to `KafkaUnboundedReader` in a separate PR.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "sjvanrossum (via GitHub)" <gi...@apache.org>.
sjvanrossum commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4937829150
Sorry for the delay, I was on parental leave. I've split this PR into #39284 and #39285.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3914434683
Reminder, please take a look at this pr: @ahmedabu98 @Abacn @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with admin client [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3541121120
## Summary of Changes
Hello @sjvanrossum, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request modernizes the KafkaIO connector by upgrading the minimum supported Kafka client version and refactoring how end offsets are retrieved. By switching from the Consumer client to the more efficient Admin client for offset requests, the change significantly improves memory performance and reintroduces asynchronous background processing for these operations. This update ensures better resource utilization and aligns the connector with more recent Kafka client capabilities.
### Highlights
* **Kafka Version Upgrade**: The minimum required Kafka client library version has been updated to 2.8.2 or newer, removing support for older versions (2.0.1, 2.3.1, 2.4.1, 2.5.1).
* **Memory Efficiency Improvement**: The KafkaIO connector now leverages the Kafka Admin client instead of the Consumer client for requesting end offsets. This change significantly reduces memory usage, with profiling showing a 90% reduction for end offset requests.
* **Restored Background Thread Feature**: The Admin client returns a KafkaFuture for each request, which is fulfilled by an I/O thread managed by the Kafka client library. This restores the background thread feature for offset requests that was previously removed.
* **API Modernization**: New methods like `withAdminFactoryFn` have been added to `KafkaIO.Read` and `KafkaIO.ReadSourceDescriptors` to allow users to provide a custom Admin client factory, enhancing flexibility and supporting different Kafka Admin versions.
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4155943556
@an2x @johnjcasey could you please help here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3871435960
Reminder, please take a look at this pr: @ahmedabu98 @Abacn @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with admin client [beam]
Posted by "sjvanrossum (via GitHub)" <gi...@apache.org>.
sjvanrossum commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3541427183
Note that this change may break `KafkaIO` configurations with complex `Consumer` factories. A `Consumer` factory should not be used to alter the environment (a `JvmInitializer` is more fitting) or configuration (a configuration supplier property should be added). I'm actually thinking we should keep the existing implementation alongside the new and check if users have provided a custom `Consumer` factory and only use the new implementation when that isn't the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "sjvanrossum (via GitHub)" <gi...@apache.org>.
sjvanrossum commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3676173245
Took another look at some stashed changes and removed the second client altogether. Kafka 3.0.0 added a method that returns current lag for a partition from a consumer's local state (last received end offset minus last known position).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3705211138
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
R: @damccorm for label build.
R: @johnjcasey for label kafka.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4281549022
waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4826170580
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4117872740
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @chamikaramj for label java.
R: @liferoad for label build.
R: @johnjcasey for label kafka.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3699179426
Reminder, please take a look at this pr: @ahmedabu98 @liferoad @fozzie15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3744012910
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @chamikaramj for label java.
R: @Abacn for label build.
R: @jrmccluskey for label kafka.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3817314410
Reminder, please take a look at this pr: @kennknowles @damccorm @johnjcasey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4273640925
Reminder, please take a look at this pr: @Abacn @damccorm @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with admin client [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3541898606
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3834813396
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @ahmedabu98 for label java.
R: @Abacn for label build.
R: @kennknowles for label kafka.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4758018714
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "sjvanrossum (via GitHub)" <gi...@apache.org>.
sjvanrossum commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3684232860
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3784101772
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
R: @damccorm for label build.
R: @johnjcasey for label kafka.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3772612858
Reminder, please take a look at this pr: @chamikaramj @Abacn @jrmccluskey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4097656973
Reminder, please take a look at this pr: @ahmedabu98 @Abacn @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3874919173
@sjvanrossum do you need a reviewer here? If so, could work with @an2x to find one? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #36834: [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition)
URL: https://github.com/apache/beam/pull/36834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "sjvanrossum (via GitHub)" <gi...@apache.org>.
sjvanrossum commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4054656245
@tvalentyn yes, this PR still needs a reviewer.
@an2x any recommendations?
I've just merged the base branch into the PR branch so everything should be up to date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3916664473
waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3684341591
Assigning reviewers:
R: @ahmedabu98 for label java.
R: @liferoad for label build.
R: @fozzie15 for label kafka.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "sjvanrossum (via GitHub)" <gi...@apache.org>.
sjvanrossum commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3684223614
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-3728679650
Reminder, please take a look at this pr: @kennknowles @damccorm @johnjcasey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4214258488
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label java.
R: @damccorm for label build.
R: @chamikaramj for label kafka.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KafkaIO] Replace end offset consumer with sum of Consumer.position(TopicPartition) and Consumer.currentLag(TopicPartition) [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36834:
URL: https://github.com/apache/beam/pull/36834#issuecomment-4198983937
Reminder, please take a look at this pr: @chamikaramj @liferoad @johnjcasey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org