You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2025/02/10 02:15:35 UTC

Re: [PR] [fix][broker] Make InflightReadsLimiter asynchronous and apply it for replay queue reads [pulsar]

BewareMyPower commented on PR #23901:
URL: https://github.com/apache/pulsar/pull/23901#issuecomment-2646772705

   This PR is too huge as a "bug fix". How could a bug fix be so huge?
   
   It's more like a new feature, in which a fix is hidden. In addition to https://github.com/apache/pulsar/issues/23952 you found, we also found a memory leak due to `ByteBuf` objects not released.
   
   BTW, I agree with @heesung-sn's comment [here](https://github.com/apache/pulsar/pull/23901#issuecomment-2617532772).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org