[jira] [Closed] (GROOVY-9112) Clean bad smell in `GroovyClassLoader`

["Daniel Sun (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GROOVY-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Sun closed GROOVY-9112.
------------------------------
       Resolution: Fixed
    Fix Version/s: 3.0.0-beta-2

Fixed by [https://github.com/apache/groovy/commit/5e0cef8b89d4ebc5c4f0f2e3cdc394e555225cfa]

> Clean bad smell in `GroovyClassLoader`
> --------------------------------------
>
>                 Key: GROOVY-9112
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9112
>             Project: Groovy
>          Issue Type: Improvement
>            Reporter: Daniel Sun
>            Assignee: Daniel Sun
>            Priority: Major
>              Labels: breaking
>             Fix For: 3.0.0-beta-2
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The type of {{classCache}} can not represent its true responsibility:
>  {{protected final Map<String, Class> classCache = new UnlimitedConcurrentCache<String, Class>();}}
> So I propose to change the type to {{EvictableCache<String, Class>}}
> Similarly,  {{protected final Map<String, Class> sourceCache = new StampedCommonCache<String, Class>();}} has the same bad smell
> It will be a breaking change, but it is time to clean the historical bad smell in a big version like Groovy 3.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)