You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/05 18:21:24 UTC

[GitHub] [pulsar] addisonj opened a new pull request #6881: [Broker] Handle all exceptions from `topic.addProducer`

addisonj opened a new pull request #6881:
URL: https://github.com/apache/pulsar/pull/6881


   Fixes #6872
   Fixes #6416
   
   ### Motivation
   
   If a producer tries to create a producer to a topic that is currently
   unloading, we can get a `RuntimeException` from
   `BrokerService.checkTopicNsOwnership` which is bubbled up through
   `topic.addProducer`. By only handling a `BrokerServiceException` this
   results in a future that never completes and results in producers not
   being able to be created if this topic is scheduled back to this broker.
   
   ### Modifications
   
   Change to handling all exceptions
   
   ### Verifying this change
   
   This could use a test, but I am currently not sure where would be the best place to test it. Existing tests should pass.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): n
     - The public API: n
     - The schema: n
     - The default values of configurations: n
     - The wire protocol: n
     - The rest endpoints: n
     - The admin cli options: n
     - Anything that affects deployment: n
   
   ### Documentation
   
     - Does this pull request introduce a new feature? n
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] addisonj commented on pull request #6881: [Broker] Handle all exceptions from `topic.addProducer`

Posted by GitBox <gi...@apache.org>.
addisonj commented on pull request #6881:
URL: https://github.com/apache/pulsar/pull/6881#issuecomment-624307856


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org