[jira] [Commented] (NIFI-3165) RemoteProcessGroupPort change doesn't update revision immediately

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731607#comment-15731607 ] 

ASF GitHub Bot commented on NIFI-3165:
--------------------------------------

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/1308

    NIFI-3165: Update RPG revision when RPGPort is updated.

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] N/A If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] N/A If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] N/A If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] N/A If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] N/A Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-3165

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1308
    
----
commit 6b41b081d22811e41be3e3b9eb547a1f6216fce7
Author: Koji Kawamura <ij...@apache.org>
Date:   2016-12-08T09:00:17Z

    NIFI-3165: Update RPG revision when RPGPort is updated.

----


> RemoteProcessGroupPort change doesn't update revision immediately
> -----------------------------------------------------------------
>
>                 Key: NIFI-3165
>                 URL: https://issues.apache.org/jira/browse/NIFI-3165
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>    Affects Versions: 1.0.0
>            Reporter: Koji Kawamura
>            Priority: Trivial
>
> In nf-remote-process-group-ports.js there're two TODO comments remaining:
> {code}
> // TODO - update the revision
> // nf.Client.setRevision(response.revision);
> {code}
> [initRemotePortConfigurationDialog|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-remote-process-group-ports.js#L71]: executed when a port configuration is updated by clicking the "Apply" button on "Configure Remote Port" window.
> [createPortOption|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-remote-process-group-ports.js#L301]: executed when a port is enabled or disabled by clicking the toggle button on "Remote Process Group Ports" window.
> Both operation send a PUT request to /nifi-api/remote-process-groups/<rpg-id>/input-ports/<port-id> (or output-ports), using RPG's revision.
> But as written with the TODO comments, these functions don't update revision to the one returned as a response of the PUT requests.
> This doesn't cause any issues because NiFi REST API allows update requests even its revision is not the latest, as long as the last update was made by the same user.
> Also, NiFi UI refreshes whole data flow periodically, and update RPG's revision automatically.
> However, the TODO should be addressed, by updating revision in cached object in NiFi UI immediately after those PUT requests, using the response data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)