You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by ch...@gmail.com on 2010/10/15 02:27:32 UTC

Only parse the lockedDomainSuffix when locked domain is enabled (issue2524041)

Reviewers: dev_shindig.apache.org,

Description:
Simple change to only parse the lockedDomainSuffix  in each container
when gadgets.uri.iframe.lockedDomainRequired is set to true.

This prevents RuntimeExceptions complaining about
gadgets.uri.iframe.lockedDomainSuffix not having a value when the
feature is lockedDomainRequired false.

Please review this at http://codereview.appspot.com/2524041/

Affected files:
    
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java


Index:  
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
===================================================================
---  
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java	 
(revision 1022774)
+++  
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java	 
(working copy)
@@ -74,9 +74,11 @@

      Collection<String> containers = config.getContainers();
      List<String> ldSuffixes =  
Lists.newArrayListWithCapacity(containers.size());
+    if (ldEnabled) {
      for (String container : containers) {
        ldSuffixes.add(getReqVal(container, LOCKED_DOMAIN_SUFFIX_KEY));
      }
+    }
      this.ldSuffixes = Collections.unmodifiableList(ldSuffixes);
    }