You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Timo Walther (JIRA)" <ji...@apache.org> on 2019/07/30 16:10:00 UTC

[jira] [Closed] (FLINK-13466) Rename Batch/StreamTableSourceFactory methods for avoiding name clashes

     [ https://issues.apache.org/jira/browse/FLINK-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timo Walther closed FLINK-13466.
--------------------------------
    Resolution: Won't Fix

It seems that the clashes are acceptable given that both context are equivalent and we force users to implement just one {{createTableSink}} or {{createTableSource}} method. I will close this issue for now.

> Rename Batch/StreamTableSourceFactory methods for avoiding name clashes
> -----------------------------------------------------------------------
>
>                 Key: FLINK-13466
>                 URL: https://issues.apache.org/jira/browse/FLINK-13466
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / API
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> FLINK-11067 introduced {{org.apache.flink.table.factories.BatchTableSourceFactory#createTableSource}} and {{org.apache.flink.table.factories.StreamTableSourceFactory#createTableSource}}. Those methods should have more specific names in order to prevent name clashes when implementing both interfaces.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)