You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "YuangGao (via GitHub)" <gi...@apache.org> on 2026/10/26 00:00:02 UTC

[PR] fix(services/azfile): authorize rename source with the configured SAS token [opendal]

YuangGao opened a new pull request, #8432:
URL: https://github.com/apache/opendal/pull/8432

   # Which issue does this PR close?
   
   N/A.
   
   # Rationale for this change
   
   With a SAS token, azfile rename fails with `403 AuthorizationFailure`: `x-ms-file-rename-source` carries the bare source URL, and Azure Files authorizes the source separately from the request URI, which is the only place the SAS gets appended. The Azure Java SDK appends the SAS to the rename source for the same reason (`ShareFileClient#renameWithResponse`).
   
   # What changes are included in this PR?
   
   - Append the configured `sas_token` to the rename source URL.
   
   Verified against a real Azure Files share: with a config SAS token, the 4 rename behavior tests fail on main with `403` and pass here (116/116); config account key passes on both. A SAS token from the environment is not covered, since azfile only reads credentials from the environment after #8423.
   
   # Are there any user-facing changes?
   
   azfile rename now works with a SAS token.
   
   # Breaking changes
   
   # AI Usage Statement
   AI-assisted implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org