[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8991: more flush timeout for emitter tests

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #8991: more flush timeout for emitter tests
URL: https://github.com/apache/incubator-druid/pull/8991#discussion_r354080846
 
 

 ##########
 File path: core/src/test/java/org/apache/druid/java/util/emitter/core/HttpEmitterTest.java
 ##########
 @@ -70,6 +70,7 @@ public void timeoutEmptyQueue() throws IOException, InterruptedException
     final HttpEmitterConfig config = new HttpEmitterConfig.Builder("http://foo.bar")
         .setBatchingStrategy(BatchingStrategy.ONLY_EVENTS)
         .setHttpTimeoutAllowanceFactor(timeoutAllowanceFactor)
+        .setFlushTimeout(5000)
 
 Review comment:
   To make it easier to adjust the timeout later if needed, perhaps have a common `HttpEmitterConfig.Builder` for the tests that sets the flush timeout to the appropriate value.
   
   Or a named constant for the value, which can also be used for the new prop value added in `ParametrizedUriEmitterTest`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org