You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by anoopsharma00 <gi...@git.apache.org> on 2016/02/19 20:21:40 UTC

[GitHub] incubator-trafodion pull request: JIRA TRAFODION-1825. Fix for cor...

GitHub user anoopsharma00 opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/331

    JIRA TRAFODION-1825. Fix for core caused by input datetime values.

    When a datetime value is input as a param or used in a literal, 
    it needs to exactly match the corresponding datatype.
    For ex: '2010-01-01' is the correct format for DATE datatype.
    But it is not the right format for TIMESTAMP datatype.
    This is done for values that are input from sqlci, jdbc/odbc params, trafci
    and literals.
    
    On the other hand, if a value is converted using the cast function, then
    the source value is extended with trailing zeroes.
    For ex:  cast ('2010-01-01' as timestamp) will result in '2010-01-01 00:00:00.000'.
    
    These 2 cases are now handled correctly. It was causing a memory overflow
    which resulted in a core.
    
    This checkin also fixes an error display bug that was not displaying the correct
    datatype.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anoopsharma00/incubator-trafodion master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #331
    
----
commit 44fb4f562fc98e274c0a7d30fd6fba7b7b0737ca
Author: Cloud User <ce...@ansharma-3.novalocal>
Date:   2016-02-19T15:31:30Z

    JIRA TRAFODION-1825. Fix for core caused by input datetime values.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: JIRA TRAFODION-1825. Fix for cor...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafodion/pull/331


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---