You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:57:00 UTC

[GitHub] [echarts] pissang commented on a change in pull request #15141: fix(treemap): label.show=false will throw error

pissang commented on a change in pull request #15141:
URL: https://github.com/apache/echarts/pull/15141#discussion_r650401192



##########
File path: src/chart/treemap/TreemapView.ts
##########
@@ -979,6 +979,9 @@ function renderNode(
             }
         );
 
+        if (!isShow) {

Review comment:
       textEl is also needed when label is set `emphasis.show = true`. Perhaps we can check if `textEl` is null in the next line instead of check if show on normal state.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org