You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/20 01:33:20 UTC

[GitHub] [airflow] mik-laj commented on pull request #13183: fix parenthesis preventing keda ScaledObject creation

mik-laj commented on pull request #13183:
URL: https://github.com/apache/airflow/pull/13183#issuecomment-748549890


   > to do so, had to make schema validation optional cus the existing validator could not find schema. maybe this is cus it's a custom resource def? @dimberman maybe you know?
   
   Disabling schema validation only for a few exceptional cases, I think is a good solution. We will have to be more careful in our reviews, but if it's not frequent, that's not a problem.
   
   If this is a problem then we will have to implement support for CRDs that have JSON Schema specifications, but this is an extra effort. We can do it later if needed.
   https://github.com/kedacore/keda/blob/main/config/crd/bases/keda.sh_scaledobjects.yaml


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org