You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by fujunwei <gi...@git.apache.org> on 2015/02/04 09:42:36 UTC

[GitHub] cordova-mobile-spec pull request: Add a "--webview" flag to create...

GitHub user fujunwei opened a pull request:

    https://github.com/apache/cordova-mobile-spec/pull/118

    Add a "--webview" flag to createmobilespec.js

    Use Crosswalk webview instead of Android webview with "--webview=crosswalk"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fujunwei/cordova-mobile-spec crosswalk-plugin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-mobile-spec/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #118
    
----
commit b38d21c863f7aa33be743213321d6dd6c6e17df6
Author: fujunwei <ju...@intel.com>
Date:   2015-02-04T08:42:57Z

    Add a "--webview" flag to createmobilespec.js
    
    Use Crosswalk webview instead of Android webview with "--webview=crosswalk"

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-mobile-spec pull request: Add a "--webview" flag to create...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-mobile-spec/pull/118


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-mobile-spec pull request: Add a "--webview" flag to create...

Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/118#issuecomment-72874844
  
    Just made it add it from the git URL if it's not checked out. This will be a short-lived thing anyways, as we'll want the plugin to be hosted on the registry anyways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-mobile-spec pull request: Add a "--webview" flag to create...

Posted by fujunwei <gi...@git.apache.org>.
Github user fujunwei commented on the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/118#issuecomment-72810628
  
    @agrieve Mybe we need git clone cordova-crosswalk-engine in top dir manually, is it right? PTAL. thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org