[GitHub] [maven-javadoc-plugin] rfscholte commented on a change in pull request #104: [MJAVADOC-694] Avoid empty warn message from getResolvePathResult

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #104:
URL: https://github.com/apache/maven-javadoc-plugin/pull/104#discussion_r734981945



##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
         }
         catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
         {
-            Throwable cause = e;
-            while ( cause.getCause() != null )
+            if ( getLog().isDebugEnabled() )
             {
-                cause = cause.getCause();
+                getLog().debug( "resole path for: " + artifactFile + " cause error: " + e.getMessage(), e );

Review comment:
       type in `resove` (missing the L)

##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -5543,12 +5543,10 @@ private ResolvePathResult getResolvePathResult( File artifactFile )
         }
         catch ( IOException | RuntimeException /* e.g java.lang.module.FindException */ e )
         {
-            Throwable cause = e;
-            while ( cause.getCause() != null )
+            if ( getLog().isDebugEnabled() )
             {
-                cause = cause.getCause();
+                getLog().debug( "resole path for: " + artifactFile + " cause error: " + e.getMessage(), e );

Review comment:
       Don't write the stacktrace, it is not useful. If the message is empty, it must be fixed in plexus-java.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org