You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by cr...@apache.org on 2006/01/17 22:56:03 UTC
svn commit: r369940 - in
/struts/shale/trunk/core-library/src/java/org/apache/shale:
resources/Bundle.properties util/ConverterHelper.java
Author: craigmcc
Date: Tue Jan 17 13:55:55 2006
New Revision: 369940
URL: http://svn.apache.org/viewcvs?rev=369940&view=rev
Log:
Throw an informative ConverterException if conversion is requested for a type
that has no by-type converter registered.
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/resources/Bundle.properties
struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java
Modified: struts/shale/trunk/core-library/src/java/org/apache/shale/resources/Bundle.properties
URL: http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/resources/Bundle.properties?rev=369940&r1=369939&r2=369940&view=diff
==============================================================================
--- struts/shale/trunk/core-library/src/java/org/apache/shale/resources/Bundle.properties (original)
+++ struts/shale/trunk/core-library/src/java/org/apache/shale/resources/Bundle.properties Tue Jan 17 13:55:55 2006
@@ -60,3 +60,6 @@
tiles.dispatchingToTile=Dispatching to tile {0}
tiles.dispatchingToViewHandler=Dispatching {0} to the default view handler
+# org.apache.shale.util.ConverterHelper
+convHelper.noConverter=You have requested a conversion for type {0}, but there is no by-type converter registered for this type
+
Modified: struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java
URL: http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java?rev=369940&r1=369939&r2=369940&view=diff
==============================================================================
--- struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java (original)
+++ struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java Tue Jan 17 13:55:55 2006
@@ -34,6 +34,17 @@
public class ConverterHelper {
+ // -------------------------------------------------------- Static Variables
+
+
+ /**
+ * <p>Messages for this class.</p>
+ */
+ private static Messages messages =
+ new Messages("org.apache.shale.resources.Bundle",
+ ConverterHelper.class.getClassLoader());
+
+
// ---------------------------------------------------------- Public Methods
@@ -88,11 +99,18 @@
*/
private Converter converter(FacesContext context, Class type) {
+ Converter converter = null;
try {
- return context.getApplication().createConverter(type);
+ converter = context.getApplication().createConverter(type);
} catch (FacesException e) {
throw new ConverterException(e);
}
+ if (converter == null) {
+ throw new ConverterException(messages.getMessage("convHelper.noConverter",
+ context.getViewRoot().getLocale(),
+ new Object[] { type.getName() }));
+ }
+ return converter;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org