[jira] [Updated] (BOOKKEEPER-602) we should have request timeouts rather than channel timeout in PerChannelBookieClient

["Ivan Kelly (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BOOKKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-602:
----------------------------------

    Attachment: 0001-BOOKKEEPER-602-we-should-have-request-timeouts-rathe.patch

I've rebased this patch to trunk. I made some small mods also. getReadTimeout() and setReadTimeout are now deprecated. The old timeout mechanism has been removed (the original patch still had it in). Lastly, i've made the default add timeout call getReadTimeout(). This is to maintain behavioural compatibility for now. I'm fine with changing it in the future, but I'd like to see some numbers first to be sure we're not hitting a lot of false positives. I'm guessing the experience you guys have is with your branch, which also has a lot of other performance improvements.

> we should have request timeouts rather than channel timeout in PerChannelBookieClient
> -------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-602
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-602
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 4.2.0, 4.2.1
>            Reporter: Sijie Guo
>            Assignee: Aniruddha
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-602-we-should-have-request-timeouts-rathe.patch, BOOKKEEPER-602.diff, BOOKKEEPER-602.diff
>
>
> currently we only have readTimeout in netty channel, it timeouts only when there is no activities in that channel, but it can't track timeouts of individual requests. if a channel continues having read entry activities, it might shadow a slow add entry response, which is bad impacting add latency.



--
This message was sent by Atlassian JIRA
(v6.1#6144)