You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "mdproctor (via GitHub)" <gi...@apache.org> on 2024/03/15 01:42:14 UTC
[PR] Split Beta Nodes #5787 [incubator-kie-drools]
mdproctor opened a new pull request, #5788:
URL: https://github.com/apache/incubator-kie-drools/pull/5788
Notes in the issue #5787
[ #5787](https://github.com/apache/incubator-kie-drools/issues/5787)
I am not looking to merge this yet; still working on cleaning up the code and changing the names of classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Split Beta Nodes #5787 [incubator-kie-drools]
Posted by "Rikkola (via GitHub)" <gi...@apache.org>.
Rikkola commented on PR #5788:
URL: https://github.com/apache/incubator-kie-drools/pull/5788#issuecomment-2893946374
Rebase and conflicts removed here https://github.com/Rikkola/drools/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Split Beta Nodes #5787 [incubator-kie-drools]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #5788:
URL: https://github.com/apache/incubator-kie-drools/pull/5788#issuecomment-1998885676
**PR job** `#1` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u https://github.com/apache/incubator-kie-drools/pull/5788 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/display/redirect
**Test results:**
- PASSED: 21899
- FAILED: 12
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testAddRemoveFacts[KieBase_type=CLOUD_IDENTITY]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testAddRemoveFacts[KieBase type=CLOUD_IDENTITY]</a></summary>
class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testSharedRian2[KieBase_type=CLOUD_IDENTITY]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRian2[KieBase type=CLOUD_IDENTITY]</a></summary>
class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testSharedRianWithFire[KieBase_type=CLOUD_IDENTITY]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRianWithFire[KieBase type=CLOUD_IDENTITY]</a></summary>
class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testRemoveRuleWithSharedRia[KieBase_type=CLOUD_IDENTITY]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testRemoveRuleWithSharedRia[KieBase type=CLOUD_IDENTITY]</a></summary>
class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testReaddRulesSharedRianDoubleNots[KieBase_type=CLOUD_IDENTITY]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testReaddRulesSharedRianDoubleNots[KieBase type=CLOUD_IDENTITY]</a></summary>
class org.drools.core.reteoo.NotRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.NotRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testSharedRian[KieBase_type=CLOUD_IDENTITY]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRian[KieBase type=CLOUD_IDENTITY]</a></summary>
class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testAddRemoveFacts[KieBase_type=CLOUD_IDENTITY_MODEL_PATTERN]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testAddRemoveFacts[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]</a></summary>
class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testSharedRian2[KieBase_type=CLOUD_IDENTITY_MODEL_PATTERN]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRian2[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]</a></summary>
class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testSharedRianWithFire[KieBase_type=CLOUD_IDENTITY_MODEL_PATTERN]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRianWithFire[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]</a></summary>
class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testRemoveRuleWithSharedRia[KieBase_type=CLOUD_IDENTITY_MODEL_PATTERN]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testRemoveRuleWithSharedRia[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]</a></summary>
class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testReaddRulesSharedRianDoubleNots[KieBase_type=CLOUD_IDENTITY_MODEL_PATTERN]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testReaddRulesSharedRianDoubleNots[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]</a></summary>
class org.drools.core.reteoo.NotRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.NotRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5788/1/testReport/org.drools.compiler.integrationtests.incrementalcompilation/AddRemoveRulesTest/testSharedRian[KieBase_type=CLOUD_IDENTITY_MODEL_PATTERN]/">org.drools.compiler.integrationtests.incrementalcompilation.AddRemoveRulesTest.testSharedRian[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]</a></summary>
class org.drools.core.reteoo.ExistsRight cannot be cast to class org.drools.core.reteoo.LeftTupleNode (org.drools.core.reteoo.ExistsRight and org.drools.core.reteoo.LeftTupleNode are in unnamed module of loader 'app')
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Split Beta Nodes #5787 [incubator-kie-drools]
Posted by "Rikkola (via GitHub)" <gi...@apache.org>.
Rikkola commented on PR #5788:
URL: https://github.com/apache/incubator-kie-drools/pull/5788#issuecomment-3421021795
This work was merged in in another PR. This one can be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Split Beta Nodes #5787 [incubator-kie-drools]
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on PR #5788:
URL: https://github.com/apache/incubator-kie-drools/pull/5788#issuecomment-1999473885
Hi Mark, let's please merge this after we release Apache 10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Split Beta Nodes #5787 [incubator-kie-drools]
Posted by "mariofusco (via GitHub)" <gi...@apache.org>.
mariofusco closed pull request #5788: Split Beta Nodes #5787
URL: https://github.com/apache/incubator-kie-drools/pull/5788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Split Beta Nodes #5787 [incubator-kie-drools]
Posted by "mariofusco (via GitHub)" <gi...@apache.org>.
mariofusco commented on code in PR #5788:
URL: https://github.com/apache/incubator-kie-drools/pull/5788#discussion_r1528232596
##########
drools-core/src/main/java/org/drools/core/reteoo/ReteooBuilder.java:
##########
@@ -201,9 +201,9 @@ public void removeTerminalNode(RuleRemovalContext context, TerminalNode tn, Coll
private Collection<BaseNode> removeNodes(AbstractTerminalNode terminalNode, Collection<InternalWorkingMemory> wms, RuleRemovalContext context) {
Map<Integer, BaseNode> stillInUse = new HashMap<>();
- Collection<ObjectSource> alphas = new HashSet<>();
+ Collection<ObjectSource> alphas = new ArrayList<>();
Review Comment:
We used a Set here to be sure of not traversing and processing the same nodes more than once, are you sure that there are no longer duplication and it is now save to use a List instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Split Beta Nodes #5787 [incubator-kie-drools]
Posted by "Rikkola (via GitHub)" <gi...@apache.org>.
Rikkola commented on PR #5788:
URL: https://github.com/apache/incubator-kie-drools/pull/5788#issuecomment-2915588037
I ran the benchmarks and they are ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Split Beta Nodes #5787 [incubator-kie-drools]
Posted by "mdproctor (via GitHub)" <gi...@apache.org>.
mdproctor commented on code in PR #5788:
URL: https://github.com/apache/incubator-kie-drools/pull/5788#discussion_r1595442938
##########
drools-core/src/main/java/org/drools/core/reteoo/ReteooBuilder.java:
##########
@@ -201,9 +201,9 @@ public void removeTerminalNode(RuleRemovalContext context, TerminalNode tn, Coll
private Collection<BaseNode> removeNodes(AbstractTerminalNode terminalNode, Collection<InternalWorkingMemory> wms, RuleRemovalContext context) {
Map<Integer, BaseNode> stillInUse = new HashMap<>();
- Collection<ObjectSource> alphas = new HashSet<>();
+ Collection<ObjectSource> alphas = new ArrayList<>();
Review Comment:
I'll check this, when I rebase again after 10.0 and fix conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Split Beta Nodes #5787 [incubator-kie-drools]
Posted by "mdproctor (via GitHub)" <gi...@apache.org>.
mdproctor commented on PR #5788:
URL: https://github.com/apache/incubator-kie-drools/pull/5788#issuecomment-2002698564
> Hi Mark, let's please merge this after we release Apache 10.
Yes that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org