You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/30 06:00:20 UTC
[GitHub] [skywalking] wingwong-knh opened a new pull request #6655: Refine concepts and designs
wingwong-knh opened a new pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `2.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 56.75% 58.79% +2.03%
- Complexity 4092 4192 +100
============================================
Files 1005 999 -6
Lines 25170 25066 -104
Branches 2455 2446 -9
============================================
+ Hits 14286 14738 +452
+ Misses 9654 9044 -610
- Partials 1230 1284 +54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/PercentMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9QZXJjZW50TWV0cmljcy5qYXZh) | `90.90% <0.00%> (-9.10%)` | `5.00% <0.00%> (-1.00%)` | |
| [...e/parser/listener/MultiScopesAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9NdWx0aVNjb3Blc0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `70.89% <0.00%> (-2.12%)` | `26.00% <0.00%> (-2.00%)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.90% <0.00%> (-1.21%)` | `16.00% <0.00%> (-2.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `64.28% <0.00%> (-0.90%)` | `12.00% <0.00%> (-1.00%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | | | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | | | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | | | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | | | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | | | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | | | |
| ... and [51 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `2.29%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 52.08% 54.38% +2.29%
- Complexity 3758 3935 +177
============================================
Files 1005 998 -7
Lines 25017 24871 -146
Branches 2441 2424 -17
============================================
+ Hits 13031 13526 +495
+ Misses 10880 10145 -735
- Partials 1106 1200 +94
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [137 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `2.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 56.75% 58.79% +2.03%
- Complexity 4092 4192 +100
============================================
Files 1005 999 -6
Lines 25170 25066 -104
Branches 2455 2446 -9
============================================
+ Hits 14286 14738 +452
+ Misses 9654 9044 -610
- Partials 1230 1284 +54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/PercentMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9QZXJjZW50TWV0cmljcy5qYXZh) | `90.90% <0.00%> (-9.10%)` | `5.00% <0.00%> (-1.00%)` | |
| [...e/parser/listener/MultiScopesAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9NdWx0aVNjb3Blc0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `70.89% <0.00%> (-2.12%)` | `26.00% <0.00%> (-2.00%)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.90% <0.00%> (-1.21%)` | `16.00% <0.00%> (-2.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `64.28% <0.00%> (-0.90%)` | `12.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | | | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | | | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | | | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | | | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | | | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | | | |
| ... and [51 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `2.10%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 49.49% 47.38% -2.11%
+ Complexity 3642 2868 -774
============================================
Files 1005 844 -161
Lines 24986 21174 -3812
Branches 2439 2021 -418
============================================
- Hits 12366 10033 -2333
+ Misses 11571 10359 -1212
+ Partials 1049 782 -267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| ... and [215 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.56%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 50.32% 49.76% -0.57%
+ Complexity 3680 3014 -666
============================================
Files 1005 844 -161
Lines 24986 21192 -3794
Branches 2439 2022 -417
============================================
- Hits 12575 10546 -2029
+ Misses 11329 9782 -1547
+ Partials 1082 864 -218
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| ... and [243 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.76%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 48.49% 47.73% -0.77%
+ Complexity 3594 2777 -817
============================================
Files 1005 813 -192
Lines 24986 20271 -4715
Branches 2439 1933 -506
============================================
- Hits 12117 9676 -2441
+ Misses 11835 9846 -1989
+ Partials 1034 749 -285
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| ... and [250 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `0.36%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 56.57% 56.93% +0.36%
+ Complexity 4086 4067 -19
============================================
Files 1005 999 -6
Lines 25170 24962 -208
Branches 2455 2438 -17
============================================
- Hits 14239 14213 -26
+ Misses 9718 9502 -216
- Partials 1213 1247 +34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| ... and [91 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `0.86%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 54.95% 55.81% +0.86%
- Complexity 3951 3995 +44
============================================
Files 1005 998 -7
Lines 25152 24889 -263
Branches 2454 2429 -25
============================================
+ Hits 13822 13892 +70
+ Misses 10171 9789 -382
- Partials 1159 1208 +49
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [154 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `6.58%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 37.46% 30.87% -6.59%
+ Complexity 2605 1916 -689
============================================
Files 974 812 -162
Lines 24025 20081 -3944
Branches 2344 1918 -426
============================================
- Hits 9002 6201 -2801
+ Misses 14345 13405 -940
+ Partials 678 475 -203
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...analyzer/provider/meter/process/SampleBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL21ldGVyL3Byb2Nlc3MvU2FtcGxlQnVpbGRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rovider/trace/parser/SegmentParserServiceImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9TZWdtZW50UGFyc2VyU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.38%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 50.32% 49.94% -0.39%
+ Complexity 3680 3020 -660
============================================
Files 1005 844 -161
Lines 24986 21192 -3794
Branches 2439 2022 -417
============================================
- Hits 12575 10585 -1990
+ Misses 11329 9736 -1593
+ Partials 1082 871 -211
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| ... and [245 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `1.44%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 48.78% 47.33% -1.45%
+ Complexity 3607 2867 -740
============================================
Files 1005 844 -161
Lines 24986 21174 -3812
Branches 2439 2021 -418
============================================
- Hits 12189 10023 -2166
+ Misses 11760 10370 -1390
+ Partials 1037 781 -256
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| ... and [221 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/b1e3d293ceb6d60ea652ccf47f0c478622870425?el=desc) (b1e3d29) will **increase** coverage by `0.58%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 5befe7f. Consider uploading reports for the commit 5befe7f to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 53.70% 54.29% +0.58%
- Complexity 4140 4192 +52
============================================
Files 1796 1796
Lines 38483 38483
Branches 4236 4236
============================================
+ Hits 20669 20895 +226
+ Misses 16817 16593 -224
+ Partials 997 995 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `69.49% <0.00%> (-5.09%)` | `12.00% <0.00%> (-3.00%)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.59% <0.00%> (+1.52%)` | `63.00% <0.00%> (+1.00%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.03% <0.00%> (+1.78%)` | `24.00% <0.00%> (ø%)` | |
| [.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==) | `73.21% <0.00%> (+1.78%)` | `8.00% <0.00%> (+1.00%)` | |
| [...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh) | `77.94% <0.00%> (+2.94%)` | `17.00% <0.00%> (+1.00%)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `63.41% <0.00%> (+4.87%)` | `6.00% <0.00%> (+1.00%)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (+9.23%)` | `7.00% <0.00%> (+2.00%)` | |
| [...pm/agent/core/remote/EventReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0V2ZW50UmVwb3J0U2VydmljZUNsaWVudC5qYXZh) | `85.13% <0.00%> (+10.81%)` | `9.00% <0.00%> (ø%)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `66.66% <0.00%> (+12.49%)` | `10.00% <0.00%> (+4.00%)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <0.00%> (+16.66%)` | `3.00% <0.00%> (+1.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [7d06c21...5befe7f](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `2.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 56.57% 58.58% +2.01%
- Complexity 4086 4181 +95
============================================
Files 1005 999 -6
Lines 25170 25066 -104
Branches 2455 2446 -9
============================================
+ Hits 14239 14685 +446
+ Misses 9718 9094 -624
- Partials 1213 1287 +74
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...rest/ManagementServiceReportPropertiesHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VSZXBvcnRQcm9wZXJ0aWVzSGFuZGxlci5qYXZh) | `27.58% <0.00%> (-62.07%)` | `2.00% <0.00%> (-2.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (-40.01%)` | `1.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/PercentMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9QZXJjZW50TWV0cmljcy5qYXZh) | `90.90% <0.00%> (-9.10%)` | `5.00% <0.00%> (-1.00%)` | |
| [.../server/library/server/jetty/JettyJsonHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2pldHR5L0pldHR5SnNvbkhhbmRsZXIuamF2YQ==) | `30.55% <0.00%> (-8.34%)` | `9.00% <0.00%> (-2.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...e/parser/listener/MultiScopesAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9NdWx0aVNjb3Blc0FuYWx5c2lzTGlzdGVuZXIuamF2YQ==) | `69.84% <0.00%> (-3.18%)` | `25.00% <0.00%> (-3.00%)` | |
| [...trace/parser/listener/SegmentAnalysisListener.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9TZWdtZW50QW5hbHlzaXNMaXN0ZW5lci5qYXZh) | `75.90% <0.00%> (-1.21%)` | `16.00% <0.00%> (-2.00%)` | |
| [.../provider/trace/parser/listener/SourceBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9Tb3VyY2VCdWlsZGVyLmphdmE=) | `92.91% <0.00%> (-0.79%)` | `11.00% <0.00%> (-1.00%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | | | |
| ... and [58 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.53%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 54.95% 54.42% -0.54%
+ Complexity 3951 3938 -13
============================================
Files 1005 998 -7
Lines 25152 24872 -280
Branches 2454 2428 -26
============================================
- Hits 13822 13536 -286
+ Misses 10171 10138 -33
- Partials 1159 1198 +39
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [172 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 50.32% 50.18% -0.15%
+ Complexity 3680 3030 -650
============================================
Files 1005 844 -161
Lines 24986 21192 -3794
Branches 2439 2022 -417
============================================
- Hits 12575 10635 -1940
+ Misses 11329 9684 -1645
+ Partials 1082 873 -209
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
| ... and [246 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `0.46%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 53.94% 54.40% +0.46%
- Complexity 3879 3937 +58
============================================
Files 1005 998 -7
Lines 25048 24871 -177
Branches 2446 2424 -22
============================================
+ Hits 13513 13532 +19
+ Misses 10401 10140 -261
- Partials 1134 1199 +65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [157 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 54.95% 55.03% +0.07%
- Complexity 3951 3960 +9
============================================
Files 1005 998 -7
Lines 25152 24889 -263
Branches 2454 2429 -25
============================================
- Hits 13822 13697 -125
+ Misses 10171 9984 -187
- Partials 1159 1208 +49
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [167 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.70%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 51.99% 51.28% -0.71%
+ Complexity 3749 3082 -667
============================================
Files 1005 844 -161
Lines 25017 21192 -3825
Branches 2441 2022 -419
============================================
- Hits 13007 10869 -2138
+ Misses 10904 9431 -1473
+ Partials 1106 892 -214
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [256 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `6.06%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 48.49% 42.42% -6.07%
+ Complexity 3594 2559 -1035
============================================
Files 1005 813 -192
Lines 24986 20245 -4741
Branches 2439 1933 -506
============================================
- Hits 12117 8589 -3528
+ Misses 11835 10993 -842
+ Partials 1034 663 -371
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.60% <0.00%> (-83.79%)` | `2.00% <0.00%> (-9.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [305 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `0.45%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 53.96% 54.41% +0.45%
- Complexity 3880 3937 +57
============================================
Files 1005 998 -7
Lines 25048 24872 -176
Branches 2446 2428 -18
============================================
+ Hits 13517 13534 +17
+ Misses 10396 10140 -256
- Partials 1135 1198 +63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [155 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `0.45%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 53.96% 54.42% +0.45%
- Complexity 3880 3938 +58
============================================
Files 1005 998 -7
Lines 25048 24872 -176
Branches 2446 2428 -18
============================================
+ Hits 13517 13536 +19
+ Misses 10396 10138 -258
- Partials 1135 1198 +63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [156 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `1.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 54.95% 56.15% +1.19%
- Complexity 3951 4016 +65
============================================
Files 1005 999 -6
Lines 25152 24934 -218
Branches 2454 2433 -21
============================================
+ Hits 13822 14001 +179
+ Misses 10171 9707 -464
- Partials 1159 1226 +67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [143 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.23%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 56.57% 56.34% -0.24%
+ Complexity 4086 4022 -64
============================================
Files 1005 999 -6
Lines 25170 24934 -236
Branches 2455 2433 -22
============================================
- Hits 14239 14048 -191
+ Misses 9718 9654 -64
- Partials 1213 1232 +19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [103 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 50.32% 50.23% -0.10%
+ Complexity 3680 3036 -644
============================================
Files 1005 844 -161
Lines 24986 21192 -3794
Branches 2439 2022 -417
============================================
- Hits 12575 10645 -1930
+ Misses 11329 9674 -1655
+ Partials 1082 873 -209
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
| ... and [251 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `0.64%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 52.08% 52.72% +0.64%
+ Complexity 3758 3142 -616
============================================
Files 1005 844 -161
Lines 25017 21195 -3822
Branches 2441 2022 -419
============================================
- Hits 13031 11176 -1855
+ Misses 10880 9107 -1773
+ Partials 1106 912 -194
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [276 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `1.11%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 55.07% 56.18% +1.11%
- Complexity 3962 4018 +56
============================================
Files 1005 999 -6
Lines 25152 24934 -218
Branches 2454 2433 -21
============================================
+ Hits 13852 14010 +158
+ Misses 10142 9701 -441
- Partials 1158 1223 +65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [136 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/b1e3d293ceb6d60ea652ccf47f0c478622870425?el=desc) (b1e3d29) will **increase** coverage by `0.58%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 3ddb584. Consider uploading reports for the commit 3ddb584 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 53.70% 54.29% +0.58%
- Complexity 4140 4192 +52
============================================
Files 1796 1796
Lines 38483 38483
Branches 4236 4236
============================================
+ Hits 20669 20895 +226
+ Misses 16817 16593 -224
+ Partials 997 995 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `69.49% <0.00%> (-5.09%)` | `12.00% <0.00%> (-3.00%)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.59% <0.00%> (+1.52%)` | `63.00% <0.00%> (+1.00%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.03% <0.00%> (+1.78%)` | `24.00% <0.00%> (ø%)` | |
| [.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==) | `73.21% <0.00%> (+1.78%)` | `8.00% <0.00%> (+1.00%)` | |
| [...skywalking/apm/agent/core/boot/ServiceManager.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlTWFuYWdlci5qYXZh) | `77.94% <0.00%> (+2.94%)` | `17.00% <0.00%> (+1.00%)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `63.41% <0.00%> (+4.87%)` | `6.00% <0.00%> (+1.00%)` | |
| [...g/oap/log/analyzer/dsl/spec/filter/FilterSpec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9maWx0ZXIvRmlsdGVyU3BlYy5qYXZh) | `44.61% <0.00%> (+9.23%)` | `7.00% <0.00%> (+2.00%)` | |
| [...pm/agent/core/remote/EventReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0V2ZW50UmVwb3J0U2VydmljZUNsaWVudC5qYXZh) | `85.13% <0.00%> (+10.81%)` | `9.00% <0.00%> (ø%)` | |
| [...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTG9nUXVlcnlEQU8uamF2YQ==) | `66.66% <0.00%> (+12.49%)` | `10.00% <0.00%> (+4.00%)` | |
| [...alking/oap/log/analyzer/dsl/spec/AbstractSpec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9kc2wvc3BlYy9BYnN0cmFjdFNwZWMuamF2YQ==) | `66.66% <0.00%> (+16.66%)` | `3.00% <0.00%> (+1.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [9a3e835...3ddb584](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/430ca80b15921bb5b6cbddc0c560b39c82171e7b?el=desc) (430ca80) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 7c6218f. Consider uploading reports for the commit 7c6218f to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 54.27% 54.29% +0.01%
- Complexity 4191 4192 +1
============================================
Files 1796 1796
Lines 38500 38483 -17
Branches 4241 4236 -5
============================================
- Hits 20897 20895 -2
+ Misses 16609 16593 -16
- Partials 994 995 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `87.09% <0.00%> (-3.23%)` | `9.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `76.00% <0.00%> (-2.00%)` | `10.00% <0.00%> (-1.00%)` | |
| [...oap/server/receiver/envoy/als/mx/FieldsHelper.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L0ZpZWxkc0hlbHBlci5qYXZh) | `90.56% <0.00%> (-1.86%)` | `6.00% <0.00%> (-5.00%)` | |
| [...walking/oap/server/library/util/ResourceUtils.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUmVzb3VyY2VVdGlscy5qYXZh) | `73.68% <0.00%> (-1.32%)` | `3.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `64.28% <0.00%> (-0.90%)` | `12.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `62.38% <0.00%> (-0.45%)` | `12.00% <0.00%> (ø%)` | |
| [...ugin/spring/mvc/commons/ReactiveRequestHolder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9SZWFjdGl2ZVJlcXVlc3RIb2xkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...er/storage/plugin/influxdb/query/MetricsQuery.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRyaWNzUXVlcnkuamF2YQ==) | `44.44% <0.00%> (+1.01%)` | `9.00% <0.00%> (+1.00%)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `69.72% <0.00%> (+1.08%)` | `25.00% <0.00%> (ø%)` | |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `77.77% <0.00%> (+1.38%)` | `14.00% <0.00%> (+1.00%)` | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [4af2b61...7c6218f](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `0.86%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 54.95% 55.82% +0.86%
- Complexity 3951 3997 +46
============================================
Files 1005 998 -7
Lines 25152 24889 -263
Branches 2454 2429 -25
============================================
+ Hits 13822 13894 +72
+ Misses 10171 9787 -384
- Partials 1159 1208 +49
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [153 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `1.60%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 48.49% 46.88% -1.61%
+ Complexity 3594 2848 -746
============================================
Files 1005 844 -161
Lines 24986 21174 -3812
Branches 2439 2021 -418
============================================
- Hits 12117 9928 -2189
+ Misses 11835 10477 -1358
+ Partials 1034 769 -265
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| ... and [222 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `1.34%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 56.57% 57.91% +1.34%
- Complexity 4086 4138 +52
============================================
Files 1005 999 -6
Lines 25170 25066 -104
Branches 2455 2446 -9
============================================
+ Hits 14239 14518 +279
+ Misses 9718 9277 -441
- Partials 1213 1271 +58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...rest/ManagementServiceReportPropertiesHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VSZXBvcnRQcm9wZXJ0aWVzSGFuZGxlci5qYXZh) | `27.58% <0.00%> (-62.07%)` | `2.00% <0.00%> (-2.00%)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `4.34% <0.00%> (-52.18%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ver/core/alarm/provider/expression/Expression.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9leHByZXNzaW9uL0V4cHJlc3Npb24uamF2YQ==) | `31.25% <0.00%> (-43.75%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ap/server/core/alarm/provider/WebhookCallback.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9XZWJob29rQ2FsbGJhY2suamF2YQ==) | `25.00% <0.00%> (-42.50%)` | `2.00% <0.00%> (-2.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `53.33% <0.00%> (-40.01%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [75 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `3.57%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 48.49% 44.91% -3.58%
+ Complexity 3594 2661 -933
============================================
Files 1005 813 -192
Lines 24986 20252 -4734
Branches 2439 1933 -506
============================================
- Hits 12117 9097 -3020
+ Misses 11835 10464 -1371
+ Partials 1034 691 -343
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.60% <0.00%> (-83.79%)` | `2.00% <0.00%> (-9.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../core/profile/analyze/ProfileAnalyzeCollector.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplQ29sbGVjdG9yLmphdmE=) | `16.66% <0.00%> (-83.34%)` | `1.00% <0.00%> (-5.00%)` | |
| ... and [279 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `2.41%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 49.90% 47.49% -2.42%
+ Complexity 3659 2874 -785
============================================
Files 1005 844 -161
Lines 24986 21174 -3812
Branches 2439 2021 -418
============================================
- Hits 12470 10056 -2414
+ Misses 11448 10336 -1112
+ Partials 1068 782 -286
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
| ... and [209 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `2.61%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 50.32% 47.71% -2.62%
+ Complexity 3680 2881 -799
============================================
Files 1005 844 -161
Lines 24986 21174 -3812
Branches 2439 2021 -418
============================================
- Hits 12575 10103 -2472
+ Misses 11329 10277 -1052
+ Partials 1082 794 -288
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...torage/plugin/jdbc/mysql/MySQLStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxTdG9yYWdlUHJvdmlkZXIuamF2YQ==) | `8.47% <0.00%> (-74.58%)` | `3.00% <0.00%> (-6.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| ... and [210 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.70%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 51.99% 51.28% -0.71%
+ Complexity 3749 3081 -668
============================================
Files 1005 844 -161
Lines 25017 21192 -3825
Branches 2441 2022 -419
============================================
- Hits 13007 10868 -2139
+ Misses 10904 9432 -1472
+ Partials 1106 892 -214
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [257 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `1.83%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 52.56% 54.40% +1.83%
- Complexity 3794 3937 +143
============================================
Files 1005 998 -7
Lines 25045 24871 -174
Branches 2446 2424 -22
============================================
+ Hits 13166 13532 +366
+ Misses 10757 10140 -617
- Partials 1122 1199 +77
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `0.44%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 53.96% 54.40% +0.44%
- Complexity 3880 3937 +57
============================================
Files 1005 998 -7
Lines 25048 24871 -177
Branches 2446 2424 -22
============================================
+ Hits 13517 13532 +15
+ Misses 10396 10140 -256
- Partials 1135 1199 +64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [157 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 50.32% 50.16% -0.16%
+ Complexity 3680 3028 -652
============================================
Files 1005 844 -161
Lines 24986 21192 -3794
Branches 2439 2022 -417
============================================
- Hits 12575 10632 -1943
+ Misses 11329 9687 -1642
+ Partials 1082 873 -209
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...apm/network/trace/component/OfficialComponent.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9PZmZpY2lhbENvbXBvbmVudC5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...walking/apm/commons/datacarrier/buffer/Buffer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-71.43%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [.../apache/skywalking/apm/util/ConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-64.05%)` | `0.00% <0.00%> (-16.00%)` | |
| ... and [245 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **increase** coverage by `1.07%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
+ Coverage 54.95% 56.02% +1.07%
- Complexity 3951 4013 +62
============================================
Files 1005 999 -6
Lines 25152 24934 -218
Branches 2454 2433 -21
============================================
+ Hits 13822 13969 +147
+ Misses 10171 9747 -424
- Partials 1159 1218 +59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `3.97%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 58.26% 54.29% -3.98%
- Complexity 4174 4192 +18
============================================
Files 1005 1796 +791
Lines 25192 38483 +13291
Branches 2456 4236 +1780
============================================
+ Hits 14679 20895 +6216
- Misses 9239 16593 +7354
+ Partials 1274 995 -279
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7InsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdJbnNlcnRSZXF1ZXN0LmphdmE=) | `83.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (ø%)` | |
| [...server/core/analysis/worker/AlarmNotifyWorker.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL0FsYXJtTm90aWZ5V29ya2VyLmphdmE=) | `85.71% <0.00%> (-14.29%)` | `3.00% <0.00%> (ø%)` | |
| [.../server/core/analysis/data/ReadWriteSafeCache.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9SZWFkV3JpdGVTYWZlQ2FjaGUuamF2YQ==) | `68.18% <0.00%> (-10.77%)` | `3.00% <0.00%> (ø%)` | |
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `66.66% <0.00%> (-10.26%)` | `4.00% <0.00%> (ø%)` | |
| [...lemetry/prometheus/PrometheusHistogramMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c0hpc3RvZ3JhbU1ldHJpY3MuamF2YQ==) | `70.58% <0.00%> (-9.42%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1245 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6655: Refine concepts and designs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6655:
URL: https://github.com/apache/skywalking/pull/6655#issuecomment-810489720
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=h1) Report
> Merging [#6655](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=desc) (eeaf42c) into [master](https://codecov.io/gh/apache/skywalking/commit/523944a59f7e6f8a3ed6f92b50401f733ffad6a5?el=desc) (523944a) will **decrease** coverage by `0.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head eeaf42c differs from pull request most recent head 0cd4a1a. Consider uploading reports for the commit 0cd4a1a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6655 +/- ##
============================================
- Coverage 56.41% 56.22% -0.20%
+ Complexity 4080 4019 -61
============================================
Files 1005 999 -6
Lines 25170 24934 -236
Branches 2455 2433 -22
============================================
- Hits 14200 14019 -181
+ Misses 9764 9692 -72
- Partials 1206 1223 +17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (-82.36%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [106 more](https://codecov.io/gh/apache/skywalking/pull/6655/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=footer). Last update [523944a...0cd4a1a](https://codecov.io/gh/apache/skywalking/pull/6655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org