[jira] [Commented] (BEAM-1100) Consider removing pylint from mvn verify

["Daniel Halperin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831361#comment-15831361 ] 

Daniel Halperin commented on BEAM-1100:
---------------------------------------

Just ran into this issue now. To be included in a Beam release -- which is a tarball of the source code -- the build process must not assume it's in a git repo.

> Consider removing pylint from mvn verify
> ----------------------------------------
>
>                 Key: BEAM-1100
>                 URL: https://issues.apache.org/jira/browse/BEAM-1100
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Assignee: Ahmet Altay
>            Priority: Critical
>
> pylint depends on git commands for getting a list of changed files to run the linter on. This does not make sense in some cases (for example when in the case code was copied/packaged out of git structure). A few possible remedies could be considered:
> - Remove pylint step from mvn verify
> - Add an option to pylint run on whole code base and use this in mvn verify
> - Change pylint to run on the whole code base (instead of just changed files)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)